WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12881 closed enhancement (fixed)

Add hooks in /wp-includes/nav-menu.php for get menu items and set menu item.

Reported by: mikeschinkel Owned by: ryan
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

Add same named hooks on the return values of both the wp_get_nav_menu_items() and wp_setup_nav_menu_item() functions from /wp-includes/nav-menu.php, patch included.

See the following thread for background.

Request for Patch:

http://lists.automattic.com/pipermail/wp-hackers/2010-April/031463.html

Start of thread:

http://lists.automattic.com/pipermail/wp-hackers/2010-April/031433.html

Attachments (3)

new_hooks_for_nav-menu.php.diff (471 bytes) - added by mikeschinkel 4 years ago.
Hooks on return values of wp_get_nav_menu_items() and wp_setup_nav_menu_item() in /wp-includes/nav-menu.php
nav_menus_hook.diff (417 bytes) - added by ptahdunbar 4 years ago.
adds a hook to the top of the nav menus admin for WooThemes branding
nav_menus_admin_hooks.diff (663 bytes) - added by ptahdunbar 4 years ago.
adds a hook to the top and bottom of the nav menus admin

Download all attachments as: .zip

Change History (7)

mikeschinkel4 years ago

Hooks on return values of wp_get_nav_menu_items() and wp_setup_nav_menu_item() in /wp-includes/nav-menu.php

comment:1 ptahdunbar4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r14031

comment:2 nacin4 years ago

  • Milestone changed from Unassigned to 3.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening. I'd like to see a thorough audit for hooks when we're done. Mike's patch was only one example.

ptahdunbar4 years ago

adds a hook to the top of the nav menus admin for WooThemes branding

ptahdunbar4 years ago

adds a hook to the top and bottom of the nav menus admin

comment:3 ptahdunbar4 years ago

  • Keywords has-patch added

comment:4 ryan4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.