WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 9 years ago

#12986 closed feature request (wontfix)

Enhancement to comments_popup_link()

Reported by: zeo's profile zeo Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-refresh dev-feedback
Focuses: Cc:

Description

Currently "Comments Off" is wrap with <span> tag, but not "Enter your password to view comments." if post requires password.

The idea is to wrap "Enter your password to view comments." with span tag, have its own css class e.g enter-password. Also adds $css_class if set. This way, theme author can easily style it based on post / comment status condition.

And add another paramater $password so that theme author can customize the text to display if post is password protected.

Need 2nd opinion with the attached patch.

Attachments (1)

comments_popup_link.patch​ (3.4 KB) - added by zeo 15 years ago.

Download all attachments as: .zip

Change History (5)

@zeo
15 years ago

#1 @zeo
15 years ago

  • Milestone changed from Unassigned to 3.0

#2 @nacin
15 years ago

  • Milestone changed from 3.0 to Future Release

#3 @chriscct7
10 years ago

  • Keywords needs-refresh dev-feedback added; has-patch removed

Patch needs a refresh, and the ticket needs to be re-reviewed by core team, as this was never implemented.

#4 @chriscct7
9 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

No forward movement in 6 years. Closing as wontfix.

Note: See TracTickets for help on using tickets.