Custom Post Type with Custom Icon Retains Post Icon Ghost

[wmrom]

When I attach an icon to a custom post type in the latest 3.0beta1 version, the ghost of a 'post' icon was still visible. On hover, the 'ghost image' is covered by my icon, though I can see parts of it sticking out from the edges.

The problem is from the fact that the <li> item still had the 'menu-icon-posts' class, calling the posts background image, but slapping the new icon on top. It uses opacity to get the same effect that the other menu items get, hence the ghost image underneath it. I've fixed the problem and included the diff from wp-admin/menu.php, as well as screenshots.

[wmrom]

Diff file showing changes

[wmrom]

A screenshot of the icon when not hovering

[wmrom]

A screenshot of the icon when hovering

[matthewhollett]

I've noticed this too, would be great if it was fixed.

[nacin]

Going to simplify it a little further and rename all of the classes to .menu-icon-(post|page) instead of posts/pages. Thus, we can simply use the post type name (sanitized). We've already renamed them from IDs this cycle, so nothing broken beyond what we've already broken.

I wonder if we should we add the IDs back in, in case a plugin is currently selecting them.

[nacin]

(In [14100]) Fix menu icons for custom post types. Fixes #12992, props wmrom.