WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 4 years ago

#13605 closed enhancement (wontfix)

Add filter for admin-ajax get-tagcloud's arguments for wp_generate_tag_cloud

Reported by: mitchoyoshitaka Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Plugins Keywords: has-patch
Focuses: administration Cc:
PR Number:

Description

Patch attached.

Attachments (1)

13605.diff (496 bytes) - added by mitchoyoshitaka 9 years ago.
Corrected diff

Download all attachments as: .zip

Change History (9)

@mitchoyoshitaka
9 years ago

Corrected diff

#1 @mitchoyoshitaka
9 years ago

  • Keywords has-patch added

#2 follow-up: @nacin
9 years ago

Just a thought, thinking a wider use case, could we add a filter to the args directly in wp_generate_tag_cloud instead, then one could use DOING_AJAX for context?

#3 in reply to: ↑ 2 @mitchoyoshitaka
9 years ago

Replying to nacin:

Just a thought, thinking a wider use case, could we add a filter to the args directly in wp_generate_tag_cloud instead, then one could use DOING_AJAX for context?

Well, that would work too, but the only places wp_generate_tag_cloud is used, aside from this use, is in wp_tag_cloud and in the plugin popular tags display. wp_tag_cloud already takes an args argument which overrides this.

Either would work for me fine. :)

#4 @nacin
9 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @jeremyfelt
6 years ago

  • Component changed from Administration to Admin APIs
  • Focuses administration added

Not sure if there's much demand for this anymore. That said, the filter on wp_generate_tag_cloud() does make more sense than the filter before it is called. Especially because the admin ajax architecture has changed so much since this ticket.

#6 @nacin
6 years ago

  • Component changed from Admin APIs to Plugins

Sorry for the noise.

#7 @chriscct7
4 years ago

  • Keywords close added
  • Priority changed from low to normal
  • Severity changed from minor to normal

There doesn't seem to be any demand for this

#8 @DrewAPicture
4 years ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.