WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 13 years ago

Last modified 13 years ago

#14754 closed defect (bug) (wontfix)

add_query_arg() refactoring

Reported by: hakre Owned by:
Priority: normal Milestone:
Component: General Version:
Severity: normal Keywords:
Cc: Focuses:

Description

The function add_query_arg() looks like that it could benefit from a refactoring. Especially the handling of optional parameters (did introduce PHP 4 that language feature?) can benefit by a sligh touch-up.

Attached patch reflects only the first few lines of the function.

Attachments (2)

14754.patch​ (1.2 KB ) - added by hakre 16 years ago.
14754.2.patch​ (1.8 KB ) - added by hakre 16 years ago.
some more lines

Download all attachments as: .zip

Change History (6)

@hakre
16 years ago

@hakre
16 years ago

some more lines

#1 @westi
16 years ago

  • Keywords needs-unit-tests added
  • Milestone Awaiting Review → Future Release

How has this been tested?

Could you write some unit-test cases for this?

#3 @c3mdigital
13 years ago

  • Keywords close removed
  • Resolution → wontfix
  • Status new → closed

This seems like refactoring for the sake of refactoring. Is there a reason why we shouldn't be using func_get_args?

#4 @SergeyBiryukov
13 years ago

  • Keywords needs-patch needs-unit-tests removed
  • Milestone Future Release
Note: See TracTickets for help on using tickets.