WordPress.org

Make WordPress Core

Opened 9 years ago

Last modified 2 years ago

#14781 new feature request

Allow upload of PHP files as plugin

Reported by: hakre Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-refresh has-patch needs-unit-tests
Focuses: administration Cc:
PR Number:

Description

Currently allowed are only ZIP packages. Plugins that consist of a single PHP file are not supported. It would be handy if uploading a single PHP file is an option.

Attachments (3)

php_upload_func.patch​ (1.3 KB) - added by Ornani 9 years ago.
14781_2.diff​ (1.3 KB) - added by edwardw 8 years ago.
Refresh of existing patch
14781.3.diff​ (1.1 KB) - added by Mte90 2 years ago.
patch refreshed

Download all attachments as: .zip

Change History (16)

#1 @hakre
9 years ago

Related: #9757

#2 @hakre
9 years ago

Workaround: Zipping the single one PHP file (not having any directory attached) and uploading it, does the job.

#3 @nacin
9 years ago

  • Component changed from General to Upgrade/Install
  • Type changed from defect (bug) to enhancement

#4 follow-up: @dd32
9 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from enhancement to feature request

Seems like a relatively sane idea, Checks would need to be performed obviously to ensure that the file contains proper plugin headers.

#5 in reply to: ↑ 4 @hakre
9 years ago

Replying to dd32:

Seems like a relatively sane idea, Checks would need to be performed obviously to ensure that the file contains proper plugin headers.

Shouldn't we do the exact checks on the unpacked zip as well?

#6 @dd32
9 years ago

Shouldn't we do the exact checks on the unpacked zip as well?

They are done AFAIK, However skipping the unzip process would bypass that section of code.

@Ornani
9 years ago

#7 @Ornani
9 years ago

  • Keywords needs-testing added

I've attached a patch that fixes this issue functional-wise. Now you can upload a single PHP file or ZIP archives.

The thing that is not done is taking care over the texts and user messages.

Also needs testing.

#8 @Ornani
9 years ago

  • Keywords changed from needs-patch, needs-testing to needs-patch,needs-testing

@edwardw
8 years ago

Refresh of existing patch

#9 @edwardw
8 years ago

  • Keywords has-patch dev-feedback added; needs-patch needs-testing removed

#10 @chriscct7
5 years ago

  • Keywords needs-refresh added; has-patch removed

Seems like a relatively good idea. Patch needs a refresh though

#11 @chriscct7
4 years ago

  • Focuses administration added
  • Keywords has-patch added; dev-feedback removed

#12 @swissspidy
3 years ago

  • Keywords needs-unit-tests added

@Mte90
2 years ago

patch refreshed

#13 @Mte90
2 years ago

I refreshed the patch looking about how to do unit tests.
Seems that WP_Upgrader class doesn't have unit test so someone can help about?
I cannot find also an unit test for the actual code that check if the zip upload is working.

Note: See TracTickets for help on using tickets.