WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 5 years ago

#15513 closed defect (bug) (wontfix)

Home Page fails to use page template sometimes

Reported by: filosofo Owned by: filosofo
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords: has-patch
Focuses: template Cc:

Description

If a page is the home page but not also the front page and it has a page template, the page template is ignored. This behavior is counter-intuitive:

  • When editing the home-page page, either normally or with quick edit, the page template is shown as being the template.
  • When acting as a front page, a page uses its page template if available.

Attachments (1)

use-page-template-for-home-page-if-exists.15513.diff (522 bytes) - added by filosofo 9 years ago.

Download all attachments as: .zip

Change History (9)

#1 @acsnaterse
9 years ago

I've the same problem here, but this solution seems not to work for me.

I've tried to debug it a bit as far as I could and I found that on line 1415/1416 of query.php it's going wrong.

On a "working" install the $_query is empty when you have a page template as homepage. If it's not empty it should have the array keys that are in the if-statement.

However on the install where it goes wrong, this is the content (print_r) of the $_query array:

Array
(
    [page] => 
    [pagename] => 
)

Of course I can change the if statement, so it will also match these two keys, but I don;t feel that would be the right solution.

Anyone?

#2 @acsnaterse
9 years ago

Don't know what it was exactly, but it seems to work all now by using the latest nightly (from 14-12-2010).. so my comment above can be ignored..

#3 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16915]) Honor the page template when a page is the home page but not also the front page. Props filosofo. fixes #15513

#5 @nacin
9 years ago

  • Keywords 3.2-early added
  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

Per #15945 and IRC discussion.

  • Revert for 3.1. Punt to 3.2.
  • Block or reset page templates for home pages. May need an upgrade routine. Need to prevent #15945 from affecting existing pages suddenly changing on core update.

#6 @nacin
5 years ago

  • Component changed from Template to Themes
  • Focuses template added

#7 @obenland
5 years ago

  • Keywords close added; 3.2-early removed

Let's not do this. We can't assume all page templates run the loop in a way that displays post correctly.

With the patch applied, Twenty Fourteen activated, and the Contributor page template active on the page_for_posts, this is what happens: https://cloudup.com/cwLUMKHS1Ht

We also still haven't figured out a way to avoid #15945.

#8 @SergeyBiryukov
5 years ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.