Make WordPress Core

Opened 13 years ago

Closed 11 years ago

Last modified 3 years ago

#16135 closed defect (bug) (invalid)

Invalid markup in administration pages

Reported by: wahgnube's profile wahgnube Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.1
Component: Validation Keywords: has-patch
Focuses: Cc:


There still remain (related to #15287) some trivial validation errors in pages in wp-admin. I have attached two tiny patches that fix some of them.

Attachments (2)

update.php.patch (1011 bytes) - added by wahgnube 13 years ago.
themes.php.patch (533 bytes) - added by wahgnube 13 years ago.

Download all attachments as: .zip

Change History (8)

#1 follow-up: @nacin
13 years ago

Not sure where those amps get passed to. Redirect maybe? Ideally they should be escaped at the last possible point.

The br's can be closed. I thought I caught all of those.

#2 @nacin
13 years ago

Ah, they're already closed. That triggers a validation error?

#3 @wahgnube
13 years ago

Not on a default WordPress install with html_type set to text/html. A few years ago I set it to application/xhtml+xml and I've been running into tiny things like this on wp-admin ever since. (Because of wp-admin/admin-header.php
@header('Content-Type: ' . get_option('html_type') . '; charset=' . get_option('blog_charset')); )

And the only reason I changed the amps are because that file already had some amps escaped.

Last edited 13 years ago by wahgnube (previous) (diff)

#4 in reply to: ↑ 1 @scribu
13 years ago

Replying to nacin:

The br's can be closed. I thought I caught all of those.

Crokford say:

But I see people get really exercised ? about that. There's a devotion to web standards that is completely unjustified, and this is just one example, a trivial example. It's as if:

"and the Gods gave us the Web Standards, and deviation from the Web Standards is the source of All Evil!"

It turns out there's no truth in that statement at all. I know the guys who made the web standards, and there were some really bright guys in those numbers and there was some other guys who were not nearly that bright. There was a lot of time pressure, there was a lot of mismanagement, a lot of mistakes were made. Given the process that put it all together, it's amazing that it's as good as it is. But it's way far from perfect, and it's way less than we deserve.

#5 @markjaquith
13 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @dd32
11 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

Neither of these two cases apply anymore.

Note: See TracTickets for help on using tickets.