WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#16235 closed enhancement (fixed)

Site Welcome Email sent without regard to noconfirmation flag

Reported by: transom Owned by: jeremyfelt
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.1
Component: Users Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Description (last modified by dd32)

In multisite and the super_admin adds a new user to a site,
if the user is new to the network, WP sends out the welcome email (but not the confirmation of being added to the site)

In my client's use case, they were looking for the SBD (silent but deadly) mode, as in no email at all should go out.

The language implies there is "no" notification but the welcome email belies that language.

if even the welcome email should be disabled, then
in wp-admin/user-new.php (around line 108)
adding
add_filter('wpmu_welcome_user_notification', ''__return_false');
would kill the new user notification from wpmu_activate_signup() (a few lines later)

Attachments (2)

welcome.diff (819 bytes) - added by transom 9 years ago.
Add filter to kill Welcome Email if nonotification
16235.diff (795 bytes) - added by tmoorewp 8 years ago.

Download all attachments as: .zip

Change History (17)

#1 @transom
9 years ago

  • Component changed from General to Users
  • Keywords new user multisite added
  • Type changed from defect (bug) to feature request
  • Version set to 3.1

arggg - the second term of the add_filter should be the underline-underline_return_false function.

#2 @dd32
9 years ago

  • Description modified (diff)
  • Keywords needs-patch added; new user multisite removed

#3 @dd32
9 years ago

  • Keywords multisite added

#4 @nacin
9 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from feature request to enhancement

@transom
9 years ago

Add filter to kill Welcome Email if nonotification

#5 @transom
9 years ago

patch added

#6 @markjaquith
9 years ago

This looks good to me.

@tmoorewp
8 years ago

#7 @tmoorewp
8 years ago

  • Cc tim@… added
  • Keywords has-patch added; needs-patch removed

Refreshed patch against current trunk.

#8 @danielbachhuber
8 years ago

  • Cc d@… added

What about a filter in wp_new_user_notification() too, for similar end result?

#10 @chriscct7
5 years ago

Patch is still good

#11 @jeremyfelt
5 years ago

  • Milestone changed from Future Release to 4.1

This ticket was mentioned in IRC in #wordpress-dev by jeremyfelt. View the logs.


5 years ago

#13 @jeremyfelt
5 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 29880:

Do not send a welcome notification when noconfirmation has been flagged

When adding a new user to a site on the network, 2 emails are sent out - one for confirmation and one as a welcome. If the option for no confirmation is selected, neither should send.

props transom
Fixes #16235

#14 @olivier.lacroix
5 years ago

Hi there,

to be honest, I was surprised that ticking the "No confirmation" email box also prevents the "Welcome mail" to be sent, and thought it was a bug.

Is there any way to revert that behavior, i.e. create a user without sending the "confirmation email" but sending the "Welcome mail" ? I need to let my users know their passwords one way or another...

Thanks,

Olivier

#15 @transom
5 years ago

I initiated this ticket because of a similar surprise "suppressing messages still sent out a welcome email".

You'll note that the future direction of sending user passwords via email in plain text is likely to also disappear regardless of this setting - per this note on the make.wordpress.org blog
https://make.wordpress.org/core/2015/04/30/dev-chat-summary-april-29th/

The hooks and filters are still available to customize the signup experience.

Note: See TracTickets for help on using tickets.