the_content_rss() incorrectly applying filters to the_content

[Kafkaesqui]

the_content_rss() function is not applying filters to the_content_rss, but rather to the_content. This is (of course) causing issues with default filters and plugins acting upon the_content_rss.

Line 21 in feed-functions.php should be:

$content = apply_filters('the_content_rss', $content);

[ryan]

(In [3140]) Filter on the_content_rss. Props Kafkaesqui. fixes #1685

[digory]

This fix seems to have broken numerical entities. I think Line 21 should have been the same, and add a new line for Kafkaesqui's fix.

A la:

$content = apply_filters('the_content', $content);
$content = apply_filters('the_content_rss', $content);

I may be wrong, but it seems to me that apply_filters does not change the output of the_content(). Rather, apply_filters takes some filters used for the_content (namely, convert_smilies and convert_chars -- see default-filters.php) and applies them to $content for this function.

Without both of the lines I included above, ampersands come out like '&' and curly quotes and en dashes are not encoded at all. This produces bad XML.

Note how get_the_title_rss() does it. It uses apply_filters with both the_title and the_title_rss. Either it needs to look like the_content_rss() or vice versa.

[digory]

In 2.0.2, it is line 25 that should be the same, with a line added above, as in the code above. Without the filters from the_content, an XML feed I created does not encode entities.

[davidhouse]

Entities come out fine without the patch for me, but perhaps we should include both filters for consistency with the_title_rss()

[ryan]

We apply the_content_rss at the beginning of the function.

[rob1n]

Sorry, must have missed it.