WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Last modified 15 hours ago

#17146 new enhancement

Don't limit screen meta tab CSS to content within #screen-meta

Reported by: koopersmith's profile koopersmith Owned by: koopersmith's profile koopersmith
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Help/About Keywords: has-patch good-first-bug
Focuses: administration Cc:

Description

Currently, the styles for screen meta tabs are limited to items within #screen-meta. I think we should use the .screen-meta-toggle class instead, so these styles can be used elsewhere in the admin without duplicating the CSS.

I ran into this problem when working on the fullscreen plugin and adding a help tab, but not inside #screen-meta.

Attachments (1)

17146.diff​ (2.2 KB) - added by koopersmith 14 years ago.

Download all attachments as: .zip

Change History (11)

@koopersmith
14 years ago

#1 @helenyhou
13 years ago

  • Component changed from UI to Help/About
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

Reusable selectors are always happy!

#2 @chriscct7
11 years ago

  • Keywords good-first-bug added

#3 @Yahire Furniture
11 years ago

  • Keywords close added

#4 @kpdesign
11 years ago

  • Keywords close removed

#5 @chriscct7
10 years ago

  • Focuses administration added

#6 @peteris
9 years ago

Is this bug still a point?

Do I need add changes in html as well?

#7 @desrosj
5 years ago

  • Milestone set to Future Release

It looks like the #screen-meta related selectors are still the same, but there are more occurrences now.

This ticket was mentioned in ​Slack in #core by abhanonstopnews. ​View the logs.
4 years ago

This ticket was mentioned in ​PR #9285 on ​WordPress/wordpress-develop by ​@yashjawale.
15 hours ago #9

  • Keywords needs-refresh removed

Currently, the styles for screen meta tabs are limited to items within #screen-meta, this PR targets .screen-meta-toggle instead so that the styles can be used elsewhere in the admin without duplicating CSS

Trac ticket: https://core.trac.wordpress.org/ticket/17146

#10 @yashjawale
15 hours ago

Added PR with refreshed patch targeting current occurrences

Note: See TracTickets for help on using tickets.