Make WordPress Core

Opened 13 years ago

Closed 7 months ago

Last modified 4 months ago

#17247 closed enhancement (fixed)

Crop tool is automatically selected when editing an image

Reported by: andrewspittle's profile andrewspittle Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch has-screenshots
Focuses: ui, javascript Cc:

Description

The crop tool is automatically selected when editing an image with the built-in tools. This can be confusing as the crop button is greyed out and inactive by default.

To reproduce:

  1. Create a new post or page
  2. Upload an image
  3. Click the Gallery tab
  4. For the image you uploaded click "Edit Image"

The crop tool will be automatically selected. If you drag the mouse over the image it will select an area to crop.

A more intuitive behavior would be to have none of the editing tools selected by default.

Currently, the next step is presumed when you click "Edit Image." It would be better to leave the next step up to each user so that clicking "Edit Image" didn't imply a default action.

Attachments (1)

wp-image-crop-default.png (419.3 KB) - added by nickylimjj 5 years ago.
crop-selected-by-default

Download all attachments as: .zip

Change History (12)

#1 @scribu
13 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Makes sense. Normal image editors don't display this behaviour either.

Last edited 13 years ago by scribu (previous) (diff)

#2 @ericlewis
10 years ago

  • Keywords needs-patch removed

Unless we've got some low hanging fruit here, the image editor needs a complete UI overhaul.

#3 @chriscct7
8 years ago

  • Keywords needs-patch added

#4 @kirasong
8 years ago

Related: #30155

#5 @kirasong
8 years ago

  • Focuses ui javascript added

I don't think that this feature needs a complete overhaul to fix this particular bug, and would love to see it fixed separately.

This ticket was mentioned in Slack in #core-media by mike. View the logs.


7 years ago

@nickylimjj
5 years ago

crop-selected-by-default

#7 @nickylimjj
5 years ago

  • Keywords has-screenshots added

Working on this ticket from WordCamp Singapore 2019. Uploaded screenshots to show the situation. Anyone knows where in the code/file sets the crop tool by default?

#8 @SergeyBiryukov
3 years ago

Related: #48754, #52221.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


13 months ago

#10 @joedolson
7 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Some of these changes were made with #50523. Closing this ticket as fixed; given the significant changes since this ticket, I'd suggest opening a new ticket if there are specific additional changes desired. Thanks!

The crop tool is still enabled if you select a region of the editing canvas, but it's because selecting a portion of the image is interpreted as intent to crop. However, the crop button is no longer inactive by default in this situation.

#11 @swissspidy
4 months ago

  • Milestone changed from Future Release to 6.3
Note: See TracTickets for help on using tickets.