Crop tool is automatically selected when editing an image

[andrewspittle]

The crop tool is automatically selected when editing an image with the built-in tools. This can be confusing as the crop button is greyed out and inactive by default.

To reproduce:

1. Create a new post or page
2. Upload an image
3. Click the Gallery tab
4. For the image you uploaded click "Edit Image"

The crop tool will be automatically selected. If you drag the mouse over the image it will select an area to crop.

A more intuitive behavior would be to have none of the editing tools selected by default.

Currently, the next step is presumed when you click "Edit Image." It would be better to leave the next step up to each user so that clicking "Edit Image" didn't imply a default action.

[scribu]

Makes sense. Normal image editors don't display this behaviour either.

[ericlewis]

Unless we've got some low hanging fruit here, the image editor needs a complete UI overhaul.

[kirasong]

Related: #30155

[kirasong]

I don't think that this feature needs a complete overhaul to fix this particular bug, and would love to see it fixed separately.

[nickylimjj]

crop-selected-by-default

[nickylimjj]

Working on this ticket from WordCamp Singapore 2019. Uploaded screenshots to show the situation. Anyone knows where in the code/file sets the crop tool by default?

[SergeyBiryukov]

Related: #48754, #52221.

[joedolson]

Some of these changes were made with #50523. Closing this ticket as fixed; given the significant changes since this ticket, I'd suggest opening a new ticket if there are specific additional changes desired. Thanks!

The crop tool is still enabled if you select a region of the editing canvas, but it's because selecting a portion of the image is interpreted as intent to crop. However, the crop button is no longer inactive by default in this situation.