WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17422 closed defect (bug) (fixed)

Invalid argument supplied for foreach() in wp-admin\credits.php on line 75

Reported by: michaelh Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: Cc:

Description

Getting Invalid argument supplied for foreach() in C:\xampp\htdocs\wp32\wp-admin\credits.php on line 75 error clicking on Credits link in admin footer.

(3.2-beta1-17916)

Attachments (1)

Credits ‹ wp32 test — WordPress_1305313362803.png (125.0 KB) - added by michaelh 3 years ago.
Result of var_dump(get_site_transient('wordpress_credits'));

Download all attachments as: .zip

Change History (9)

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Owner set to nacin
  • Status changed from new to accepted

comment:2 nacin3 years ago

Could you do a var_dump() of get_site_transient('wordpress_credits');

I can add more defensive checks but I need to know what's wrong.

michaelh3 years ago

Result of var_dump(get_site_transient('wordpress_credits'));

comment:3 devinreams3 years ago

I'm seeing the same here, Andrew.

Here's plain text: http://d.pr/IkbJ

comment:4 nacin3 years ago

It would probably help if I deployed my changes to production. :-)

Should work now upon transient refresh.

comment:5 devinreams3 years ago

Right. Having removed the transient, credits.php loads as expected.

As I understand, anyone previously running trunk with this issue will not see it in ~12 hours or so (assuming they don't remove the transient and they've updated).

comment:6 follow-up: nacin3 years ago

credits.php gets cached for a week locally. Not ideal for testing, but no need to fetch data often.

On the other hand, since it's likely to be a rarely accessed page, I can drop it a bit.

comment:7 in reply to: ↑ 6 devinreams3 years ago

Replying to nacin:

credits.php gets cached for a week locally. Not ideal for testing, but no need to fetch data often.

Ah yes, was reading my own timeout.

On the other hand, since it's likely to be a rarely accessed page, I can drop it a bit.

Seems fine as-is. And if if the content doesn't get downloaded there's a fallback message.

Anything remaining? I vote resolving 'worksforme' (caveat: clear credits transient).

comment:8 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Thanks Devin for the help.

Note: See TracTickets for help on using tickets.