wp_redirect() should return true on success

[draca]

Ticket #3250 added the ability for a filter to cancel a redirect request and returns false in that event.

On success, there is no return value specified so the function returns NULL per the PHP spec. A value of true should be returned so that logic such as the following can be used:

if (! wp_redirect($redirect_url)) {
  // Handle redirect failure
}

[draca]

Patch for pluggable.php

[duck_]

How about doing this?

if ( wp_redirect($redirect_url) === false ) {
  // Handle redirect failure
}

[draca]

Yes, that can be done as a workaround.

I believe the fix is still relevant as it's better to return a value that will be interpreted as true on success so the simpler form of the condition clause can be used.

Alternatively, the function could return the value of $location.

[c3mdigital]

Fixed in r24996 Marking as duplicate of #24969 since it has already been committed.