WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#17480 closed enhancement (fixed)

Credits page: Have 'Get involved' Codex URL localizable

Reported by: xibe Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: trivial Version: 3.2
Component: General Keywords: has-patch dev-feedback
Focuses: Cc:

Description

Currently, the Credits page features a link to http://codex.wordpress.org/Contributing_to_WordPress, which is all fine and dandy, except for those folks who can't read English.

For those lucky enough to have a translated documentation available online, I suggest we let the URL be localizable by translators.

Attachments (2)

getInvolvedURL.patch (608 bytes) - added by xibe 10 years ago.
17480.diff (6.1 KB) - added by zeo 10 years ago.
i18n update to xibe patch.

Download all attachments as: .zip

Change History (15)

#1 @xibe
10 years ago

Damn, misspelt Nikolay's name, sorry!

#2 @scribu
10 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Owner nbaichisky deleted
  • Status changed from new to assigned

#3 @nacin
10 years ago

  • Owner set to nacin
  • Status changed from assigned to accepted

#4 @zeo
10 years ago

I assume there's no localized URL for http://wordpress.org/about/?

See: 17480.diff

Minor update to xibe original patch. Also:

  • whitespace cleanup
  • NCR

#5 @xibe
10 years ago

Thanks zeo.

WP.org is not translatable, so http://wordpress.org/about/ and http://wordpress.org/license/ are out of reach.

#6 @zeo
10 years ago

  • Keywords dev-feedback added

xibe, you're right. I refresh the patch and add changes to /wp-admin/freedoms.php too.

@zeo
10 years ago

i18n update to xibe patch.

#7 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [17960]:

Allow Codex URLs to be translated. Don't offer wp.org/about/ URLs for translation. props zeo, xibe. fixes #17480.

#8 @westi
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @westi
10 years ago

I think it is better in cases like this to translate the urls separately because:

  • It makes the strings simpler to translate if there isn't a codex url to update
  • It doesn't break the translations for everyone who isn't going to translate the codex url
  • It makes the translation of the url re-usable in more than one place - ensures consistency.

#10 @westi
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [17967]:

Move the codex link into a seperate translation so you don't have to translate it if you have not got a version in your language and you only have to translate it once. Fixes #17480

#11 follow-up: @xibe
10 years ago

Sure, the thinking makes sense, but for consistency, this should be applied to all Codex links in the POT (80-ish, if I'm not mistaken), starting with all the ones tied to contextual Help tabs, like:

<a href=\"http://codex.wordpress.org/Posts_Categories_Screen\" target=\"_blank\">Documentation on Categories</a>

It would be better, sure. But as a translator, I will curse you for making me re-link to all the 80-ish localized Codex pages :)

#12 in reply to: ↑ 11 ; follow-up: @westi
10 years ago

Replying to xibe:

Sure, the thinking makes sense, but for consistency, this should be applied to all Codex links in the POT (80-ish, if I'm not mistaken), starting with all the ones tied to contextual Help tabs, like:

<a href=\"http://codex.wordpress.org/Posts_Categories_Screen\" target=\"_blank\">Documentation on Categories</a>

It would be better, sure. But as a translator, I will curse you for making me re-link to all the 80-ish localized Codex pages :)

I think we should do this going forwards for new links and go back and change the existing ones early in 3.3.

#13 in reply to: ↑ 12 @xibe
10 years ago

Replying to westi:

I think we should do this going forwards for new links and go back and change the existing ones early in 3.3.

Fine by me.

Note: See TracTickets for help on using tickets.