Remove upload file after deleting custom background

[denzel_chia]

I came across a comment on custom-background.php that says
@todo: uploaded files are not removed here.

So, I thought I will come up with this codes for the upload file deletion if user remove background.

Attached custom-background.diff

I had tested on my localhost.

Hope this contribution is useful.

Thanks.

[ocean90]

You should use the current trunk, there is a revert in your patch, see 'context' => 'custom-background' .

[kawauso]

Not got a theme to test this with, but shouldn't we delete the attachment on reset as well?

Attaching a patch that does this and checks we actually have an attachment ID before trying to delete it.

[kawauso]

Delete on reset and check for attachment ID

[denzel_chia]

Thanks everybody for the pointers.

[nacin]

Nice initial work on this, both of you.

Because backgrounds are now stored with context => custom-background, then we're actually remembering previous backgrounds. Keeping the old background around after settings changes doesn't seem like a problem. But I'll leave that for the UX.

[celloexpressions]

4 years later, now that backgrounds are handled through the media library (and in the Customizer, see [30309], and [30459]), they definitely shouldn't be deleted when they're removed/changed from the background setting, since they can also be used elsewhere. So this ticket is no longer relevant.