WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17934 closed defect (bug) (fixed)

Gracefully degrade for PHP4

Reported by: nacin Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: General Keywords: close
Focuses: Cc:

Description

Looks like install.php, setup-config.php, and wp-load.php (possibly other locations) need to call wp_check_php_mysql_versions() before including any file beyond load.php.

Attachments (2)

17934.diff (900 bytes) - added by nacin 3 years ago.
17934.2.diff (2.8 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 ryan3 years ago

The else case of wp-load.php can include load.php and call wp_check_php_mysql_versions(). That will fix the files that use wp-load.php such as install.php. setup-config.php already loads load.php so just needs a call to wp_check_php_mysql_versions().

nacin3 years ago

nacin3 years ago

comment:2 ryan3 years ago

+1

Nicely conservative for 3.2. We can investigate reducing the number of files that must parse with PHP4 in 3.3.

comment:3 nacin3 years ago

In [18374]:

wp_check_php_mysql_versions() during setup and install. see #17934.

comment:4 nacin3 years ago

In [18375]:

Mark a few files as needing to be parsable by PHP4 in order to show the proper error messages. Non-exhaustive. see #17934.

comment:5 nacin3 years ago

  • Keywords close added
  • Resolution set to fixed
  • Status changed from new to closed

Can someone poke around on PHP4 to make sure we got everything?

comment:6 wpdavis3 years ago

I poked around a bit, tried several ways of getting in and and tried upgrading. Couldn't find any problems.

Note: See TracTickets for help on using tickets.