WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 15 months ago

#18423 reviewing enhancement

Make internal linking's River + Query constructors public

Reported by: mitchoyoshitaka Owned by: koopersmith
Milestone: Future Release Priority: normal
Severity: normal Version: 3.2
Component: Editor Keywords: has-patch
Focuses: javascript Cc:

Description

...and restructure them so that they're slightly more configurable, i.e. making the AJAX endpoint URL and result rendering overrideable.

Attachments (1)

18423.diff (13.7 KB) - added by mitchoyoshitaka 4 years ago.
Patch v1, refactored so they're in wp.lookup.Query and wp.lookup.River. Also introduces wp.utils, but this should probably be moved out into a separate file in the near future.

Download all attachments as: .zip

Change History (4)

@mitchoyoshitaka4 years ago

Patch v1, refactored so they're in wp.lookup.Query and wp.lookup.River. Also introduces wp.utils, but this should probably be moved out into a separate file in the near future.

comment:1 @mitchoyoshitaka4 years ago

  • Owner set to koopersmith
  • Status changed from new to reviewing

comment:2 @koopersmith3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version set to 3.2

I like this idea, but would prefer to iterate and tighten the code up before making it publicly available. I'd also like to wait until we properly establish a JS namespace.

Mitcho, can you elaborate on your use cases for the exposed Query and River classes?

comment:3 @jeremyfelt15 months ago

  • Focuses javascript added
Note: See TracTickets for help on using tickets.