WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#18531 closed enhancement (fixed)

Small clean up for media list table

Reported by: ocean90 Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: trivial Version:
Component: Media Keywords: has-patch
Focuses: Cc:

Description (last modified by ocean90)

  • $t_time was never used.
  • Media tags aren't supported by core.

Attachments (3)

18531.patch (2.0 KB) - added by ocean90 10 years ago.
18531.like-posts.patch (1.2 KB) - added by ocean90 9 years ago.
18531.just-t_time.patch (638 bytes) - added by ocean90 9 years ago.

Download all attachments as: .zip

Change History (11)

@ocean90
10 years ago

#1 @azaozz
9 years ago

  • Resolution set to maybelater
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

The tags support is like the custom taxonomies on the write page, don't see a reason to take it out.

#2 @azaozz
9 years ago

  • Milestone 3.3 deleted

#3 @nacin
9 years ago

  • Keywords needs-refresh added
  • Milestone set to Awaiting Review
  • Resolution maybelater deleted
  • Status changed from closed to reopened

We don't yet support custom taxonomy columns on the write page (though we should).

We shouldn't remove the column handler. We can however remove commented-out line adding it to $post_columns.

That said, I'm more interested in the other aspect of the patch, the cleanup of timestamps. Yes, it is possible for media to be unpublished, but probably nto through the API. But the rest of it looks interesting.

#4 @ocean90
9 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 3.5

#5 @ocean90
9 years ago

  • Component changed from General to Media
  • Description modified (diff)

#6 @ocean90
9 years ago

18531.like-posts.patch

  • Uses the same code as on posts list, except the schedulded/publish part
  • Introduces the filter attachment_date_column_time
  • Shows the full date via abbr

18531.just-t_time.patch

  • Just removes the unused $t_time var

#7 @ocean90
9 years ago

  • Keywords needs-refresh removed

#8 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from reopened to closed

In [21880]:

Remove unused $t_time variable. props ocean90. fixes #18531.

Note: See TracTickets for help on using tickets.