Context Navigation

← Previous Ticket
Next Ticket →

#18531 closed enhancement (fixed)

Small clean up for media list table

Reported by:	ocean90	Owned by:	nacin
Priority:	normal	Milestone:	3.5
Component:	Media	Version:
Severity:	trivial	Keywords:	has-patch
Cc:		Focuses:

Description (last modified by ocean90)

$t_time was never used.
~~Media tags aren't supported by core.~~

Attachments (3)

18531.patch (2.0 KB ) - added by ocean90 15 years ago.
18531.like-posts.patch (1.2 KB ) - added by ocean90 14 years ago.
18531.just-t_time.patch (638 bytes ) - added by ocean90 14 years ago.

Download all attachments as: .zip

Change History (11)

@ocean90
15 years ago

Attachment 18531.patch added

#1 @azaozz
15 years ago

Resolution → maybelater
Status new → closed
Type defect (bug) → enhancement

The tags support is like the custom taxonomies on the write page, don't see a reason to take it out.

#2 @azaozz
15 years ago

Milestone 3.3

#3 @nacin
15 years ago

Keywords needs-refresh added
Milestone → Awaiting Review
Resolution maybelater
Status closed → reopened

We don't yet support custom taxonomy columns on the write page (though we should).

We shouldn't remove the column handler. We can however remove commented-out line adding it to $post_columns.

That said, I'm more interested in the other aspect of the patch, the cleanup of timestamps. Yes, it is possible for media to be unpublished, but probably nto through the API. But the rest of it looks interesting.

#4 @ocean90
14 years ago

Description modified (diff)
Milestone Awaiting Review → 3.5

#5 @ocean90
14 years ago

Component General → Media
Description modified (diff)

Uses the same code as on posts list, except the schedulded/publish part
Introduces the filter attachment_date_column_time
Shows the full date via abbr

18531.just-t_time.patch

Just removes the unused $t_time var

#7 @ocean90
14 years ago

Keywords needs-refresh removed

#8 @nacin
14 years ago

Owner set to nacin
Resolution → fixed
Status reopened → closed

In [21880]:

Remove unused $t_time variable. props ocean90. fixes #18531.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#18531 closed enhancement (fixed)

Small clean up for media list table

Description (last modified by ocean90)

Attachments (3)

Change History (11)

@ocean90 15 years ago

#1 @azaozz 15 years ago

#2 @azaozz 15 years ago

#3 @nacin 15 years ago

#4 @ocean90 14 years ago

#5 @ocean90 14 years ago

@ocean90 14 years ago

@ocean90 14 years ago

#6 @ocean90 14 years ago

#7 @ocean90 14 years ago

#8 @nacin 14 years ago