WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#19150 closed defect (bug) (fixed)

Redundant caps checks in wp_admin_bar_appearance_menu()

Reported by: duck_ Owned by: duck_
Priority: normal Milestone: 3.3
Component: General Version: 3.3
Severity: normal Keywords: has-patch
Cc: Focuses:

Description 

if ( ! current_user_can('switch_themes') && ! current_user_can( 'edit_theme_options' ) )
    return;

if ( ! current_user_can( 'edit_theme_options' ) )
    return;

The first set can just be removed.

However, I think that the correct behaviour would be to display "Themes" if the user has either switch_themes or edit_theme_options and only display the rest if they have edit_theme_options.

Related: [17741] and #15931; [19006], [19026] and #18197.

Attachments (2)

19150.diff​ (909 bytes ) - added by duck_ 15 years ago.
19150.2.diff​ (1.1 KB ) - added by nacin 15 years ago.

Download all attachments as: .zip

Change History (4)

@duck_
15 years ago

#1 @nacin
15 years ago

  • Milestone Awaiting Review → 3.3

As wp_admin_bar_appearance_menu() had the parent removed, the cap checks can be simplified quite a bit.

@nacin
15 years ago

#2 @duck_
15 years ago

  • Owner set to duck_
  • Resolution → fixed
  • Status new → closed

In [19153]:

Fix caps logic in wp_admin_bar_appearance_menu(). Show Themes on either switch_themes or edit_theme_options, and the rest of the appearance items on edit_theme_options. Fixes #19150.

Note: See TracTickets for help on using tickets.