WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#19346 closed task (blessed) (fixed)

Post-update screen needs generic strings for a maintenance release

Reported by: nacin Owned by: nacin
Milestone: 3.3 Priority: low
Severity: normal Version: 3.3
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

about.php should have strings readily available for introducing and displaying a changelog, that way there are no new strings in 3.3.1.

We'll need to brainstorm this one. It's easy, just something to have a little fun with.

Needs to get done before string freeze, ideally timed with RC1.

Attachments (10)

19346.patch (4.1 KB) - added by chexee 4 years ago.
Adds suggested strings for Maintenance and bug fixes. Adds example mark up and styling for point releases.
19346.diff (2.9 KB) - added by nacin 4 years ago.
19346.styles.patch (3.7 KB) - added by chexee 4 years ago.
Styles changelog for point releases. Removed a few class names from previous versions.
19346.styles.2.patch (3.7 KB) - added by chexee 4 years ago.
removes .feature class
19346.styles.2.2.patch (1.8 KB) - added by chexee 4 years ago.
removes .feature class
19346.styles.2.3.patch (2.1 KB) - added by chexee 4 years ago.
Updates styles to completely remove div
19346.2.diff (563 bytes) - added by nacin 4 years ago.
Modifies a string to enable us to link to the release post, Codex, or elsewhere.
19346-example.diff (1.1 KB) - added by nacin 4 years ago.
Example implementation for 3.3.1 and 3.3.2.
19346.3.diff (2.3 KB) - added by nacin 4 years ago.
Refreshed 19346.styles.2.3.patch to include a small credits CSS tweak. (On min-width, it is three columns, rather than two.)
19346.4.diff (1.9 KB) - added by nacin 4 years ago.
Refresh of 19346.2.diff reflecting conversations with Nikolay and Zé.

Download all attachments as: .zip

Change History (26)

comment:1 @nacin4 years ago

  • Keywords needs-docs added

comment:2 @chexee4 years ago

Thoughts on a layout like this:
http://chx.mx//75/cyb6a6nu8sg0s.png

Two columns for each "feature." Since its not 3 columns, uneven numbered features don't look too bad, the columns don't get too narrow, and it saves some vertical space for the typical "Bugfix/Security release" nature of point releases.

Bulleted lists in lieu of paragraphs might work better here, where new fixes are typically short and sweet.

The headings are standardized here that "Bugfixes/Security issues" are the same as a Feature Heading (h3) for a major release.

@chexee4 years ago

Adds suggested strings for Maintenance and bug fixes. Adds example mark up and styling for point releases.

comment:3 @chexee4 years ago

19346.patch adds some suggested strings and example mark up and CSS.

Suggest we change the "What's New" in %s to "What's New" and head each version changelog with "In %s"

Updates some header styling as well.

Screenshot: http://chx.mx//ay/l3chbcheog8oo.png

comment:4 @nacin4 years ago

  • Keywords has-patch needs-refresh added; needs-docs removed

Jane and MarkJaquith signed off on http://cl.ly/0F0d172a0i1s2J2u312o, which I mocked up after talking with chexee and helen. (Only one would be shown — these are just the combinations.)

Working with Zé, I came up with a pile of strings that can be effectively translated. Patch attached for the strings.

We will need a CSS refresh from chexee for the desired styling. Looks like some of the CSS can be discarded. Here was the markup I used, feel free to adjust:

<div class="changelog point-release">
	<div class="feature">
		<h3>Maintenance Releases</h3>
		<p><strong>Version 3.3.2</strong> blah blah blah.</p>
		<p><strong>Version 3.3.1</strong> blah blah blah.</p>
	</div>
</div>
Last edited 4 years ago by nacin (previous) (diff)

@nacin4 years ago

comment:5 @ryan4 years ago

Looks good.

@chexee4 years ago

Styles changelog for point releases. Removed a few class names from previous versions.

comment:6 @chexee4 years ago

Added a small change to the markup, .point-releases instead of point-release

<div class="changelog point-releases">
	<div class="feature">
		<h3>Maintenance Releases</h3>
		<p><strong>Version 3.3.2</strong> blah blah blah.</p>
		<p><strong>Version 3.3.1</strong> blah blah blah.</p>
	</div>
</div>

comment:7 @nacin4 years ago

In [19536]:

Add about.php maintenance/security release strings for translation. see #19346.

@chexee4 years ago

removes .feature class

@chexee4 years ago

removes .feature class

comment:8 @chexee4 years ago

19346.styles.2.2.patch requires the following style of markup:

<div class="changelog point-releases">
	<div>
		<h3>Maintenance Releases</h3>
		<p><strong>Version 3.3.2</strong> blah blah blah.</p>
		<p><strong>Version 3.3.1</strong> blah blah blah.</p>
	</div>
	<div>
		<h3>Maintenance Releases</h3>
		<p><strong>Version 3.3.2</strong> blah blah blah.</p>
		<p><strong>Version 3.3.1</strong> blah blah blah.</p>
	</div>
</div>

@chexee4 years ago

Updates styles to completely remove div

@nacin4 years ago

Modifies a string to enable us to link to the release post, Codex, or elsewhere.

@nacin4 years ago

Example implementation for 3.3.1 and 3.3.2.

comment:9 follow-up: @nacin4 years ago

  • Keywords commit added; needs-refresh removed
  • Version set to 3.3

Suggest commit on 19346.3.diff and 19346.2.diff.

You can see 19346-example.diff for how it'll work in a maintenance release.

Last edited 4 years ago by nacin (previous) (diff)

@nacin4 years ago

Refreshed 19346.styles.2.3.patch to include a small credits CSS tweak. (On min-width, it is three columns, rather than two.)

comment:10 in reply to: ↑ 9 ; follow-up: @Zeo4 years ago

@nacin, pls refresh 19346.3.diff to add missing semi-colon (;) at the end of border: 0 (2 places).

And also, mark the release notes URL for translation?

Last edited 4 years ago by Zeo (previous) (diff)

comment:11 in reply to: ↑ 10 @SergeyBiryukov4 years ago

Replying to Zeo:

And also, mark the release notes URL for translation?

+1, that would be in a maintenance release though.

The string is already marked for translation in Admin Bar, so no new strings are required:
http://core.trac.wordpress.org/browser/trunk/wp-includes/admin-bar.php#L98

comment:12 @Zeo4 years ago

@SergeyBiryukov new string. I think the "release notes URL" is the permalink to the release announcement from wp.org blog post or codex.

Correct me if I'm wrong.

comment:13 @nacin4 years ago

We could pass ?locale= to the URL and handle the redirect server-side.

For example, wordpress.org/releases/3.3.1/?locale=pt_BR

Then /releases/ will send them off in the right location, pulling from either the codex or rosetta blog.

I would rather push this into the cloud than handle it as a translatable line.

@nacin4 years ago

Refresh of 19346.2.diff reflecting conversations with Nikolay and Zé.

comment:14 @ryan4 years ago

Looks good.

comment:15 @nacin4 years ago

In [19541]:

Tweak strings for point release changelogs. see #19346.

comment:16 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19542]:

CSS for the about.php point release changelog. props chexee, fixes #19346.

Note: See TracTickets for help on using tickets.