Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#20382 closed defect (bug) (fixed)

When the admin menu is folded, the icons aren't centered

Reported by: azaozz Owned by: azaozz
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: UI Keywords: ui-feedback
Focuses: Cc:


Noticed that when adding the retina display 2x sized icons.

Attachments (4)

before.jpg (11.0 KB) - added by azaozz 4 years ago.
after.jpg (11.2 KB) - added by azaozz 4 years ago.
20382.patch (5.1 KB) - added by azaozz 4 years ago.
20382.diff (4.7 KB) - added by helenyhou 4 years ago.

Download all attachments as: .zip

Change History (10)

@azaozz4 years ago

@azaozz4 years ago

comment:1 @azaozz4 years ago

Seems most are 1px off center, the "posts" icon 2px.

@azaozz4 years ago

comment:2 @azaozz4 years ago

Not sure if the best way to fix this is by tweaking the sprite or in the css. 20382.patch corrects it from the css.

comment:3 @azaozz4 years ago

  • Keywords ui-feedback added

comment:4 @helenyhou4 years ago

Haven't figured out what caused that to shift, since the regular sprite didn't change but still seems affected, but a CSS change seems sane enough. The post icon actually looks like it was 1px too far to the left in 3.3.1 to begin with :( 20382.patch looks good to me, testing on both regular desktop and new iPad.

@helenyhou4 years ago

comment:5 @helenyhou4 years ago

Actually, the users menu icon seemed 1px to the right. 20382.diff for that.

comment:6 @azaozz4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20400]:

Center the menu icons when the menu is folded. For proper display in RTL the width of .wp-menu-image has to be 30px. Props helenyhou, fixes #20382

Note: See TracTickets for help on using tickets.