Make WordPress Core

Opened 12 years ago

Last modified 5 years ago

#20388 new defect (bug)

?cpage=N URLs do not have canonical redirection

Reported by: markjaquith's profile markjaquith Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Canonical Keywords: has-patch
Focuses: Cc:


?cpage=N URLs aren't redirected to their pretty URL counterparts. They should be.

Attachments (1)

20388-tests.patch (740 bytes) - added by boonebgorges 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @cklosows
12 years ago

  • Cc cklosowski@… added

Tested on trunk build (3.4-beta4-20838) and this appears to be working.

localhost/wordpress/hello-world?cpage=2 -> localhost/wordpress/hello-world/comment-page-2/ (via a 301 redirect)

Last edited 12 years ago by cklosows (previous) (diff)

#3 @wonderboymusic
11 years ago

In 26091:

Set the page_comments option to true in Tests_Canonical to properly check canonical redirection for paged comments. By doing so, one assertion tied to #20388 no longer needs to be.

See #20388, 25913.

#4 @wonderboymusic
11 years ago

The redirection works when the page_comments option is true. However, the other 2 assertions that check for redirection of out of range comment pages still fail.

#5 @chriscct7
9 years ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.