Context Navigation

← Previous Ticket
Next Ticket →

#20760 closed defect (bug) (duplicate)

Erroneous use of str_replace() in setup-config.php

Reported by:	johnbillion	Owned by:
Priority:	low	Milestone:
Component:	Upgrade/Install	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

In wp-admin/setup-config.php we have an instance of str_replace() which uses a blank string in the $subject parameter. While it has no detrimental effect, it may as well be removed to avoid some head scratching.

function get_bloginfo() {
	return ( ( is_ssl() ? 'https://' : 'http://' ) . $_SERVER['HTTP_HOST'] . str_replace( $_SERVER['PHP_SELF'], '/wp-admin/setup-config.php', '' ) );
}

Attachments (2)

20760.patch (598 bytes ) - added by johnbillion 14 years ago.
20760.2.patch (670 bytes ) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (5)

@johnbillion
14 years ago

Attachment 20760.patch added

#1 @johnbillion
14 years ago

Keywords has-patch added

Patch

@SergeyBiryukov
14 years ago

Attachment 20760.2.patch added

#2 @SergeyBiryukov
14 years ago

Introduced in [13026].

I guess the idea was to return a correct URL for site in a subdirectory. Perhaps we should fix the order of arguments rather than remove the replacement.

#3 @SergeyBiryukov
14 years ago

Component General → Upgrade/Install
Milestone Awaiting Review
Resolution → duplicate
Status new → closed

#16884

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core