Removing all hooks too aggressive if a priority number is given

[GeertDD]

When you call remove_all_filters() or remove_all_actions() with a priority number (second parameter), all hooks get removed if none is found with the given priority.

Example:

<?php
global $wp_filter;

add_action('my_action', 'callback_foo');
add_action('my_action', 'callback_bar', 20);
var_dump($wp_filter['my_action']);

// At this point only callback_foo is left. Fine.
remove_all_actions('my_action', 20);
var_dump($wp_filter['my_action']);

// Exactly the same function call as above,
// but now all hooks bound to my_action are removed!
remove_all_actions('my_action', 20);
var_dump($wp_filter['my_action']);

Calling remove_all_filters() or remove_all_actions() with a priority should never remove hooks with another priority.

[mordauk]

Seems sane to me.

[valendesigns]

The 20920.diff​ patch fixes the issue and includes supporting unit tests.

Cheers,
Derek

[boonebgorges]

20920.2.diff​ reverses the if statement to make it a bit easier to read, and gives the unit test a more accurate name.

[nacin]

Looks good.

[boonebgorges]

In 31014:

In remove_all_filters(), only remove callbacks that match the $priority parameter.

Props GeertDD, valendesigns.
Fixes #20920.