#21003 closed enhancement (fixed)
WP_Comment_Query with WP_Meta_Query integration
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Comments | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Basically the title says it all. What I'd like to see in WordPress is an implementation of the WP_Meta_Query that was intorduced in 3.2 for the comments query as well as ordering by meta values.
Basically if those features are implemented, developers will have greater flexibility about comments - the first things that come to mind are rating system(I know there should be a plugin out there for that already), separating comments by some parameter(let's say age/sex/country/etc, if there is some kind of sociological study) and many more.
I stumbled upon this quite recently when I was making an extension for qTranslata and I had to get comments by specific meta value - I had to either write custom MySQL(at which I'm not really good), or implement the meta query.
I'm attaching the diff file that I made(I've tested that with 3.4) for wp-includes/comments.php
Attachments (5)
Change History (17)
#5
follow-up:
↓ 6
@
12 years ago
Unit tests can go here: http://unit-tests.trac.wordpress.org/browser/trunk/tests/comment.php#L8
#6
in reply to:
↑ 5
@
12 years ago
Replying to ryan:
Unit tests can go here: http://unit-tests.trac.wordpress.org/browser/trunk/tests/comment.php#L8
Which I just moved to http://unit-tests.trac.wordpress.org/browser/trunk/tests/comment/query.php
#7
@
12 years ago
The last assertion in those tests fails. The same comment occurs twice in the results.
#8
@
12 years ago
- Keywords commit removed
In WP_Query, we have this for dealing with duplicates:
if ( !empty( $this->tax_query->queries ) || !empty( $this->meta_query->queries ) ) { $groupby = "{$wpdb->posts}.ID"; }
#9
follow-up:
↓ 10
@
12 years ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from new to closed
In [22074]:
Patch for integrating meta_query and meta_value ordering for comments queries