WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 2 months ago

#21077 reopened enhancement

Add support for custom ports in multisite site addresses

Reported by: djzone Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.4
Component: Bootstrap/Load Keywords: needs-patch needs-unit-tests
Focuses: multisite Cc:

Description

This patch enables MultiSite to be used with a custom port, what must be defined as WP_CUSTOM_PORT in wp-config.php.

Attachments (4)

multisite-custom-port.patch (945 bytes) - added by djzone 8 years ago.
Multisite custom port patch
ms-settings_201308012128.php (1.4 KB) - added by F J Kaiser 8 years ago.
ms-settings_201201082128.patch (1.4 KB) - added by F J Kaiser 8 years ago.
Ignore previous patch - added .php extension per accident
15936.5.diff (4.6 KB) - added by jeremyfelt 4 months ago.
Prior work on custom port numbers from 15936

Download all attachments as: .zip

Change History (21)

@djzone
8 years ago

Multisite custom port patch

#1 @scribu
8 years ago

Couldn't we use parse_url() for these things?

#2 @nacin
8 years ago

Yeah. ms-settings.php could stand for a scrub.

I've never been sure why custom ports are blocked in multisite. During the merge in 3.0, we tried to clean things up, but we tried not to ask "why" too often as everything would have been a rabbit hole.

We should probably review the history in MU and then work to just allow custom ports to work, without a constant.

#3 @ipstenu
8 years ago

  • Cc ipstenu added

#4 @ipstenu
8 years ago

Looks like it was hard coded in to use 80.

http://mu.wordpress.org/forums/topic/14587

#5 @F J Kaiser
8 years ago

  • Cc 24-7@… added
  • Severity changed from normal to major

+1 Just encountered a situation where I - in a local MU setup - can't use the default port of :80/:443. Now I'm left with a core hack.

#7 @mindctrl
8 years ago

  • Cc mindctrl added

#8 @F J Kaiser
8 years ago

  • Keywords needs-testing dev-feedback added

Scribus idea with parse_url is likely the route to go. Patch following that will

  • also takes the absence of $_SERVER['HTTP_HOST'] into account and switch to $_SERVER['SERVER_NAME'] for reliability and those edge cases
  • takes the domain via parse_url() and PHP_URL_PATH
  • still falls back to the default wp_die()-message in case somehow couldn't get rid of the port

Patch needs more intense testing.

@F J Kaiser
8 years ago

Ignore previous patch - added .php extension per accident

#9 @F J Kaiser
8 years ago

  • Keywords close added; has-patch needs-testing dev-feedback removed

Closed in favor of #15936 as it seems to address IPv6 issues as well. Adding new patch there.

#10 @SergeyBiryukov
8 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #15936.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 months ago

#12 @jeremyfelt
4 months ago

  • Component changed from Multisite to Bootstrap/Load
  • Focuses multisite added
  • Keywords needs-patch needs-unit-tests added
  • Milestone set to Future Release
  • Resolution duplicate deleted
  • Severity changed from major to normal
  • Status changed from closed to reopened
  • Summary changed from Custom port patch for MultiSite to Add support for custom ports in multisite site addresses

@jeremyfelt
4 months ago

Prior work on custom port numbers from 15936

#13 @jeremyfelt
4 months ago

I've reopened this ticket since it was one of the first closed as a duplicate of #15936, which we've now closed as a separate area of focus. See also #42993, which can be considered a duplicate of this ticket. I've also attached the latest patch from #15936, 15936.5.diff, which handles some port number changes and some unnecessary IPv6 changes.

A few things to watch for / decide on:

The best place to test this now may be in the default WordPress local development environment, which uses localhost:8889 as its address and requires a port number.

This ticket was mentioned in Slack in #core-multisite by johnbillion. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.