Opened 9 years ago
Last modified 2 months ago
#21077 reopened enhancement
Add support for custom ports in multisite site addresses
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Bootstrap/Load | Keywords: | needs-patch needs-unit-tests |
Focuses: | multisite | Cc: |
Description
This patch enables MultiSite to be used with a custom port, what must be defined as WP_CUSTOM_PORT in wp-config.php.
Attachments (4)
Change History (22)
#2
@
9 years ago
Yeah. ms-settings.php could stand for a scrub.
I've never been sure why custom ports are blocked in multisite. During the merge in 3.0, we tried to clean things up, but we tried not to ask "why" too often as everything would have been a rabbit hole.
We should probably review the history in MU and then work to just allow custom ports to work, without a constant.
#5
@
8 years ago
- Cc 24-7@… added
- Severity changed from normal to major
+1 Just encountered a situation where I - in a local MU setup - can't use the default port of :80/:443. Now I'm left with a core hack.
#8
@
8 years ago
- Keywords needs-testing dev-feedback added
Scribus idea with parse_url is likely the route to go. Patch following that will
- also takes the absence of
$_SERVER['HTTP_HOST']
into account and switch to$_SERVER['SERVER_NAME']
for reliability and those edge cases - takes the domain via
parse_url()
andPHP_URL_PATH
- still falls back to the default
wp_die()
-message in case somehow couldn't get rid of the port
Patch needs more intense testing.
#9
@
8 years ago
- Keywords close added; has-patch needs-testing dev-feedback removed
Closed in favor of #15936 as it seems to address IPv6 issues as well. Adding new patch there.
#10
@
8 years ago
- Keywords close removed
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
Duplicate of #15936.
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
9 months ago
#12
@
9 months ago
- Component changed from Multisite to Bootstrap/Load
- Focuses multisite added
- Keywords needs-patch needs-unit-tests added
- Milestone set to Future Release
- Resolution duplicate deleted
- Severity changed from major to normal
- Status changed from closed to reopened
- Summary changed from Custom port patch for MultiSite to Add support for custom ports in multisite site addresses
#13
@
9 months ago
I've reopened this ticket since it was one of the first closed as a duplicate of #15936, which we've now closed as a separate area of focus. See also #42993, which can be considered a duplicate of this ticket. I've also attached the latest patch from #15936, 15936.5.diff, which handles some port number changes and some unnecessary IPv6 changes.
A few things to watch for / decide on:
- Is it enough to just support port numbers in the multisite bootstrap or should the UI fully support them as well? Things may seem a little strange at first.
- Should all port numbers be allowed or should there be a filtered list?
The best place to test this now may be in the default WordPress local development environment, which uses localhost:8889
as its address and requires a port number.
This ticket was mentioned in Slack in #core-multisite by johnbillion. View the logs.
9 months ago
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
8 months ago
This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.
8 months ago
This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.
8 months ago
#18
@
2 months ago
Should all port numbers be allowed or should there be a filtered list?
I think all port numbers should be allowed.
Story time. Yesterday I had to switch back to using MAMP PRO for local stuff. It makes both Apache and Nginx web servers available, both with http
and https
schemes, all on different ports. Depending on my /etc/hosts setup, depending on WordPress constants and options being filtered, depending on what I'm working on or testing, it's pretty convenient to have WordPress available on so many different ports.
MAMP has its own default ports but you can easily use 80/443/81/7443, or whatever you want really. The ability to use any port numbers is useful if you also have Docker/Lando running, or have Local running, or Valet, etc... especially when transitioning between environments.
I assume it would also be really useful with running multiple instances of something like VVV.
Lastly, ports are valid URL segments, even if they are weird to see. IMO, that means there is some inherent obligation to support them.
Multisite custom port patch