Add support for custom ports in multisite site addresses

[djzone]

This patch enables MultiSite to be used with a custom port, what must be defined as WP_CUSTOM_PORT in wp-config.php.

[djzone]

Multisite custom port patch

[scribu]

Couldn't we use parse_url() for these things?

[nacin]

Yeah. ms-settings.php could stand for a scrub.

I've never been sure why custom ports are blocked in multisite. During the merge in 3.0, we tried to clean things up, but we tried not to ask "why" too often as everything would have been a rabbit hole.

We should probably review the history in MU and then work to just allow custom ports to work, without a constant.

[ipstenu]

Looks like it was hard coded in to use 80.

​http://mu.wordpress.org/forums/topic/14587

[F J Kaiser]

+1 Just encountered a situation where I - in a local MU setup - can't use the default port of :80/:443. Now I'm left with a core hack.

[F J Kaiser]

Related #15936

[F J Kaiser]

Scribus idea with parse_url is likely the route to go. Patch following that will

• also takes the absence of $_SERVER['HTTP_HOST'] into account and switch to $_SERVER['SERVER_NAME'] for reliability and those edge cases
• takes the domain via parse_url() and PHP_URL_PATH
• still falls back to the default wp_die()-message in case somehow couldn't get rid of the port

Patch needs more intense testing.

[F J Kaiser]

Ignore previous patch - added .php extension per accident

[F J Kaiser]

Closed in favor of #15936 as it seems to address IPv6 issues as well. Adding new patch there.

[SergeyBiryukov]

Duplicate of #15936.

[jeremyfelt]

Prior work on custom port numbers from 15936

[jeremyfelt]

I've reopened this ticket since it was one of the first closed as a duplicate of #15936, which we've now closed as a separate area of focus. See also #42993, which can be considered a duplicate of this ticket. I've also attached the latest patch from #15936, 15936.5.diff​, which handles some port number changes and some unnecessary IPv6 changes.

A few things to watch for / decide on:

• Is it enough to just support port numbers in the multisite bootstrap or should the UI fully support them as well? Things may seem a little strange at first.
• Should all port numbers be allowed or should there be a filtered list?

The best place to test this now may be in the default WordPress local development environment, which uses localhost:8889 as its address and requires a port number.