WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#21333 closed enhancement (fixed)

Admin Toolbar - Link lacks meaningful text

Reported by: grahamarmfield Owned by: azaozz
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4.1
Component: Accessibility Keywords: has-patch
Focuses: Cc:

Description

Within the admin toolbar there is a link to the WordPress Updates page. The text for this link however is just a number - which is made up of the number of plugins, themes with new versions.

Arguably this quite important information for admins for site security etc.

The link does have a title attribute containing the breakdown of the information, but not all screen readers will read out the title attribute values of links by default.

Please can the information contained in the title attribute be repeated in the link text - as screen reader-only text. Eg:

<span class="ab-label">10<span class="screen-rdr-class??"> consists 8 Plugin Updates, 2 Theme Updates</span></span>

Attachments (3)

21333.patch (1.0 KB) - added by SergeyBiryukov 5 years ago.
21333.overlapping-title.png (1.8 KB) - added by SergeyBiryukov 5 years ago.
21333.2.patch (616 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
5 years ago

  • Keywords has-patch added

Had to add !important for some properties, since the toolbar resets them:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-includes/css/admin-bar.dev.css#L1

#2 @azaozz
5 years ago

Thinking it would be better to define a screen-reader-text class in admin-bar.css. Then it will be available on the front-end too and can override the reset without using !important.

#3 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [21425]:

Accessibility: add text to the updates link in the toolbar, props SergeyBiryukov, fixes #21333

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 3.5

#5 @SergeyBiryukov
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Previous patch introduced a bug in IE 7 and 8 (21333.overlapping-title.png), probably due to an improper use of <legend> tag. 21333.2.patch fixes that.

#6 @azaozz
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21549]:

Fix screen reader text in IE7 and 8 in the toolbar "Updates" menu, props SergeyBiryukov, fixes #21333

Note: See TracTickets for help on using tickets.