WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Last modified 10 days ago

#21516 new enhancement

Make the entire .check-column the click target for the checkbox

Reported by: mitchoyoshitaka's profile mitchoyoshitaka Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-ux-feedback dev-feedback has-patch
Focuses: accessibility Cc:

Description

Sometimes checkboxes are quite small. In various list tables, checkboxes are wrapped in a .check-column. Why not make the entire .check-column clickable, in case people (like me) miss?

Attachments (3)

21516.diff​ (851 bytes) - added by mitchoyoshitaka 11 years ago.
21516.2.diff​ (827 bytes) - added by lessbloat 11 years ago.
21516.3.diff​ (12.4 KB) - added by sabernhardt 10 days ago.
proof of concept with labels that cover their entire cell

Download all attachments as: .zip

Change History (15)

@mitchoyoshitaka
11 years ago

@lessbloat
11 years ago

#1 @lessbloat
11 years ago

Looks good to me. In 21516.2.diff I updated the patch, and made a slight tweak to include this functionality for the "check all" checkboxes in the table header row.

#2 @TacoVerdo
10 years ago

Current patch breaks checking.
Cannot use check all anymore.

#3 @joostdevalk
10 years ago

  • Keywords needs-patch added; has-patch removed

Looked at this with @TacoVerdo, this needs a new patch if we want to fix it that ties into the check all functionality. Right now it doesn't check all when it should and doesn't check the current checkbox when you click it.

#4 @chriscct7
8 years ago

  • Keywords dev-feedback added
  • Severity changed from minor to normal

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
6 years ago

#6 @karmatosed
6 years ago

  • Keywords has-ux-feedback added; ux-feedback removed

This would be great to have as an enhancement, we discussed this in our weekly design triage and it would be great to have implemented. Could we get a new patch for this?

#7 @Hareesh Pillai
22 months ago

  • Milestone changed from Awaiting Review to 5.9

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
20 months ago

#9 @audrasjb
20 months ago

  • Focuses accessibility added
  • Keywords needs-refresh 2nd-opinion added
  • Milestone changed from 5.9 to Future Release

The patch is 9 years old and needs refresh. Adding accessibility focus and 2nd-opinion. I don't think it's safe for 5.9 as it is now. Let's move to future release. Feel free to bring it back to 5.9 if a working patch is ready to go.

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
7 weeks ago

#11 @joedolson
7 weeks ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 6.3

We think this could be beneficial for accessibility by providing a larger click target for users. The JS solution isn't really necessary; if we make the label a block-level element filling the table cell & move the screen reader text class to an internal span, then we get this behavior for free.

We may want to add some kind of hover state to provide affordance that the entire cell is clickable, although the mouse cursor will provide a clue there.

@sabernhardt
10 days ago

proof of concept with labels that cover their entire cell

#12 @sabernhardt
10 days ago

  • Keywords has-patch added; needs-patch needs-refresh removed

21516.3.diff would need some polishing (indentation, etc.). Note that it does not affect the Select All checkboxes on the Updates page because those have a label in a separate cell. The hover style uses the same box-shadow as the focus style, which might confuse some mouse users after they select a checkbox and hover over another.

Note: See TracTickets for help on using tickets.