Twenty Thirteen: remove custom comment callback in favor of core `comment_form()` defaults

[lancewillett]

Related to improvements to core comment form markup, see #20088.

Notes:

• We might need to remove the Post Author span element from the output, and use CSS instead to denote the post author's comments (background color, border, etc)
• Twenty Twelve should be styled to work well with 3.4 comment form output (not just with the new #20088 output)
• Use comment_form() arguments so that plugins and child themes can override anything

[lancewillett]

Discussing in IRC dev chat yesterday, punting this to Twenty Twelve 1.1 but still intending to get it in before 3.5 stable hits.

[obenland]

Replying to lancewillett:

• We might need to remove the Post Author span element from the output, and use CSS instead to denote the post author's comments (background color, border, etc)

I think we might be able to just append it to the get_comment_author_link() output.

• Twenty Twelve should be styled to work well with 3.4 comment form output (not just with the new #20088 output)
• Use comment_form() arguments so that plugins and child themes can override anything

How is twentytwelve_comment() related to comment_form()? Did you mean wp_list_comments()?

[lancewillett]

Replying to obenland:

• Use comment_form() arguments so that plugins and child themes can override anything

How is twentytwelve_comment() related to comment_form()? Did you mean wp_list_comments()?

Yep, my mistake.

[obenland]

22005.first-pass.diff​ makes comment styling work with default 3.4 wp_list_comments() output. Actual call would be wp_list_comments( array( 'avatar_size' => 44 ) );

[nacin]

This would have been nice. What's the verdict? Doable? Not doable?

[bpetty]

I was looking over this one yesterday, and it seem like whatever is decided with #20088 is going to affect this ticket, maybe enough so that it's a dependency, so I figured since #20088 was just punted, this one probably should be too.

[lancewillett]

I agree with bpetty, this is too dependent on #20088 and not doable for 3.5 after all. Let's shoot for Twenty Thirteen not having a custom comment list function at all, out of the gate.

[bpetty]

Well, it looks like Twenty Thirteen didn't make it out of the gate without it's own custom comment list function.

[lancewillett]

bpetty -- why did you open this ticket? It's for Twenty Twelve.

[lancewillett]

Noting for next steps: once #20088 change is in core, we can update the patch here for Twenty Thirteen.

• Remove the custom callback
• Add the new html5 argument to wp_list_comments()
• Adjust any CSS to style the output from core

[lancewillett]

Love seeing all the red in .1 patch. ;)

[lancewillett]

In 23696:

Twenty Thirteen: remove custom comment callback in favor of core comment_form() defaults. Props obenland, closes #22005. See #20088.