WP Upgrader: update_bulk_plugins_complete_actions and update_bulk_theme_complete_actions should pass information about all plugins/themes to the filter

[ragulka]

In class-wp-upgrader.php, line 1214 there is this line:

$update_actions = apply_filters('update_plugin_complete_actions', $update_actions, $this->plugin);

When adding a filter to it like this:

add_filter('update_bulk_plugins_complete_actions','test_filter',99,2);

function test_filter( $update_actions, $plugins ) {
    echo print_r( $plugins, 1);
    return $update_actions;
}

Only the last updated plugin info will be printed. However, it should contain information about all the plugins that were updated (since we are dealing with a bulk upgrade here).

[ragulka]

The same applies to update_bulk_theme_complete_actions

[SergeyBiryukov]

Confirmed. The actions were added in [14879] (for #11232).

[dd32]

Suggestions for how to change this?

We can't just change the 2nd arg from the last plugin to an array of plugins, so I guess we'll probably have to add a 3rd arg for an array of plugins/themes.. not that the existing arg is exactly very useful..

[ragulka]

Replying to dd32:

Suggestions for how to change this?

We can't just change the 2nd arg from the last plugin to an array of plugins, so I guess we'll probably have to add a 3rd arg for an array of plugins/themes.. not that the existing arg is exactly very useful..

I agree that adding a 3rd argument makes most sense because it will keep backwards compatibility. Perhaps there are some kind of use cases for getting just the last upgraded plugin, so we can just keep this arg.