WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 7 years ago

#22302 closed defect (bug) (fixed)

Multisite administration - default date format

Reported by: pavelevap Owned by: jeremyfelt
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch 3.6-early
Focuses: multisite Cc:

Description

1) There is default non-translatable format for dates in multisite administration:

Sites - All sites (columns Last Updated and Registered)

Users - All users (column Registered)

Please see attached patch, I used existing localization format.

2) Sites - All sites - Edit any site. There are also Registered and Last Updated values in default date format, but I am not sure how to solve this issue...

Attachments (1)

22302.patch (1.3 KB) - added by pavelevap 9 years ago.

Download all attachments as: .zip

Change History (10)

@pavelevap
9 years ago

#1 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @kovshenin
9 years ago

  • Keywords has-patch added

Looking at 22302.patch, not sure we can drop the <br /> separator between the time and date.

#3 @nacin
9 years ago

  • Keywords 3.6-early added
  • Milestone changed from 3.5 to Future Release
  • Version changed from trunk to 3.1

What to do?

#4 follow-up: @jeremyfelt
7 years ago

  • Focuses multisite added

Looks like the only outstanding question here is what to do with the <br> when translating $date = 'Y/m/d \<\b\r \/\> g:i:s a';

This only affects excerpt view and makes https://cloudup.com/i-oHt1cTApS become https://cloudup.com/ildy4x1e7s8

I'm not sure that it matters much either way.

#5 @jeremyfelt
7 years ago

  • Milestone changed from Future Release to 4.2

#6 @DrewAPicture
7 years ago

@jeremyfelt: Would you still like to pursue a fix for this for 4.2? If not, please mark for future release.

#7 in reply to: ↑ 4 @jeremyfelt
7 years ago

Replying to jeremyfelt:

Looks like the only outstanding question here is what to do with the <br> when translating $date = 'Y/m/d \<\b\r \/\> g:i:s a';

This should be ready to go in beyond this question. :)

@sergeybiryukov, @ocean90: thoughts?

#8 @ocean90
7 years ago

I would like to avoid having the <br /> tag inside the date format. I don't think it's really neccessary and there is nothing wrong with https://cloudup.com/ildy4x1e7s8 since the column is wide enough.

The patch needs an update based on #31121.

#9 @jeremyfelt
7 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 31833:

Make dates in multisite site and user list tables translatable.

Props pavelevap.

Fixes #22302.

Note: See TracTickets for help on using tickets.