WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Last modified 7 months ago

#22330 new enhancement

Optimize regexes to remove protocol from URL

Reported by: geertdd's profile GeertDD Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4.2
Component: Formatting Keywords: has-patch needs-unit-tests needs-testing
Focuses: Cc:

Description

Regexes used to chop off the protocol of a URL should be anchored to the start of the string.

  1. The regex fails faster and thus avoid useless work. No need to look further down the URL for strings like "http://".
  2. The regex should not alter any URLs that might be contained in the query string.

Attachments (2)

22330.diff​ (4.3 KB) - added by GeertDD 13 years ago.
22330.2.diff​ (3.1 KB) - added by nacin 12 years ago.

Download all attachments as: .zip

Change History (6)

@GeertDD
13 years ago

#1 @nacin
12 years ago

  • Component changed from General to Formatting
  • Keywords needs-unit-tests needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

@nacin
12 years ago

#2 @nacin
12 years ago

  • Keywords needs-testing added; needs-refresh removed

I think 22330.2.diff​ is a full refresh of the remaining instances here. We do need to make sure that these don't break anything, though. (They look good at a glance.) In some cases these are unit-testable, as well.

#3 @chriscct7
10 years ago

  • Keywords needs-refresh added
  • Severity changed from minor to normal

This ticket was mentioned in ​PR #9208 on ​WordPress/wordpress-develop by ​@sainathpoojary.
7 months ago #4

  • Keywords needs-refresh removed

Trac ticket: #22330

Note: See TracTickets for help on using tickets.