Opened 12 years ago
Last modified 6 years ago
#22330 new enhancement
Optimize regexes to remove protocol from URL
Reported by: | GeertDD | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.4.2 |
Component: | Formatting | Keywords: | has-patch needs-unit-tests needs-testing needs-refresh |
Focuses: | Cc: |
Description
Regexes used to chop off the protocol of a URL should be anchored to the start of the string.
- The regex fails faster and thus avoid useless work. No need to look further down the URL for strings like
"http://"
. - The regex should not alter any URLs that might be contained in the query string.
Attachments (2)
Change History (5)
Note: See
TracTickets for help on using
tickets.
I think 22330.2.diff is a full refresh of the remaining instances here. We do need to make sure that these don't break anything, though. (They look good at a glance.) In some cases these are unit-testable, as well.