WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 19 months ago

Last modified 19 months ago

#22333 closed enhancement (fixed)

Add IDs to .misc-pub-section divs in meta-boxes.php

Reported by: nofearinc Owned by: helen
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.4
Component: Administration Keywords: 3.7-early has-patch commit
Focuses: Cc:

Description

In wp-admin/includes/meta-boxes.php the post_submit_meta_box has several sections with class .misc-pub-section. Should you have to style/alter any of them, it's not consistent as:

  1. first div has only class="misc-pub-section"
  2. second div has class="misc-pub-section" id="visibility"
  3. third div has class="misc-pub-section curtime"

Since this is a unique box on the screen, I've added two more IDs to div blocks 1 and 3 to allow for easier styling changes.

Attachments (3)

meta-boxes.php.patch (1.0 KB) - added by nofearinc 2 years ago.
meta-boxes.php patch for IDs
22333.2.patch (2.3 KB) - added by nofearinc 20 months ago.
adding classes to all misc boxes
22333.3.patch (6.4 KB) - added by nofearinc 20 months ago.
Adding few extra classes in other files, removing .num-revisions

Download all attachments as: .zip

Change History (12)

@nofearinc2 years ago

meta-boxes.php patch for IDs

comment:1 @SergeyBiryukov2 years ago

  • Version changed from trunk to 3.4

comment:2 @markoheijnen20 months ago

  • Keywords 3.7-early commit added

comment:3 @nacin20 months ago

Would be nice to just give these descriptive classes. IDs aren't really a necessity.

Also, there's a new .misc-pub-section in core.

comment:4 @SergeyBiryukov20 months ago

  • Keywords has-patch needs-refresh added; commit removed

@nofearinc20 months ago

adding classes to all misc boxes

comment:5 @nofearinc20 months ago

Updated the patch with classes for all pub sections. I've used the misc-pub prefix for consistency across all boxes similarly to the misc-pub-section class name itself.

comment:6 @wonderboymusic20 months ago

  • Milestone changed from Awaiting Review to 3.7

these are all marked 3.7-early

@nofearinc20 months ago

Adding few extra classes in other files, removing .num-revisions

comment:7 @nacin19 months ago

  • Keywords commit added; needs-refresh removed

comment:8 @helen19 months ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 25083:

Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333.

comment:9 @helen19 months ago

In 25297:

Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.

Note: See TracTickets for help on using tickets.