WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#22517 closed defect (bug) (fixed)

Localized strings in attachment detail (media window)

Reported by: pavelevap Owned by: koopersmith
Milestone: 3.5 Priority: low
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:
PR Number:

Description

There are some longer localized strings and it looks a little weird (alignment), please see attached screenshot...

Attachments (3)

Media_long_strings.jpg (16.4 KB) - added by pavelevap 7 years ago.
22517.patch (387 bytes) - added by ocean90 7 years ago.
Media_long_strings_2.jpg (20.8 KB) - added by pavelevap 7 years ago.

Download all attachments as: .zip

Change History (13)

#1 @nacin
7 years ago

Obviously, this could happen for either long labels or long fields. At worst, the field should be floated right. Not much else we can do there.

#2 @nacin
7 years ago

  • Component changed from I18N to Media

@ocean90
7 years ago

#3 @ocean90
7 years ago

  • Keywords has-patch added

22517.patch limits the width of the select item.

#4 follow-up: @pavelevap
7 years ago

There is also too much space left before Title and Alt text fields (they could be for example centered). Now, thumbnail is on the left, Title field is on the right and Dimension field is also on the left. It does not look very well...

#5 @nacin
7 years ago

  • Milestone changed from Awaiting Review to 3.5
  • Priority changed from normal to low

#6 @nacin
7 years ago

  • Owner set to koopersmith
  • Status changed from new to assigned

#7 @koopersmith
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 22733:

Media: Set a max width on select elements in the sidebar. fixes #22517, see #21390.

#8 in reply to: ↑ 4 @koopersmith
7 years ago

Replying to pavelevap:

There is also too much space left before Title and Alt text fields (they could be for example centered). Now, thumbnail is on the left, Title field is on the right and Dimension field is also on the left. It does not look very well...

These fields are aligned right, to be flush with their controls. When they overflow, they bump their controls below them. This sounds like expected behavior. Can you please provide a screenshot?

#9 @pavelevap
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Much better, I guess, see attached screenshot.

But there is too much space on the left side (red line on screenshot). For longer strings it would be helpful to have variable width for labels and dropdowns? Now it is probably 35 % and 65 %, but it would be better for example 30 % and 70 % for Czech and different ratio for other languages (related to length of strings). But I am not sure if it is simply possible...

#10 @koopersmith
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

The space exists not only for translations, but also for plugins. The labels are on the same line as the controls to maximize the use of vertical space. Pushing the width of all labels based on the width of the longest label is tricky using markup and CSS alone, and we'd want to impose a series of maximum widths anyway, which would likely conflict with that first process.

Given that we are in RC1, this is the way it will remain for 3.5.

Note: See TracTickets for help on using tickets.