#22584 closed defect (bug) (worksforme)
Typo: Missing blank
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
After running an update I receive the message "… updated successfully. Show DetailsHide Details." with a missing blank in "DetailsHide".
http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-upgrader.php#L1236
is
$this->upgrader->strings['skin_update_successful'] = __('%1$s updated successfully.').' <a onclick="%2$s" href="#" class="hide-if-no-js"><span>'.__('Show Details').'</span><span class="hidden">'.__('Hide Details').'</span>.</a>';
but should be
$this->upgrader->strings['skin_update_successful'] = __('%1$s updated successfully.').' <a onclick="%2$s" href="#" class="hide-if-no-js"><span>'.__('Show Details').'</span> <span class="hidden">'.__('Hide Details').'</span>.</a>';
Attachments (4)
Change History (15)
#1
follow-up:
↓ 2
@
13 years ago
- Keywords close added
They should be displayed together. Seems like the CSS file wasn't loaded here.
#2
in reply to:
↑ 1
@
13 years ago
Replying to ocean90:
They shouldn't be displayed together. Seems like the CSS file wasn't loaded here.
Also that line hasn't changed in the trunk version since 3.4.2. What are the steps to reproduce this issue?
#3
follow-up:
↓ 4
@
13 years ago
I'm curious which CSS wasn't loaded then. Can't see anything for that. Also weird to do that spacing with CSS instead of a space
#4
in reply to:
↑ 3
@
13 years ago
Replying to markoheijnen:
I'm curious which CSS wasn't loaded then.
Must be wp-admin.css, since the color exists, which is defined in color-*.css. Have in mind, that it's an iframe request.
How it does look for me: http://cl.ly/L7OX and http://cl.ly/L74e
#5
@
13 years ago
I've attempted to reproduce this on 3.4.2 and on 3.5-RC1. In both, I never get output beyond "Downloading update from http://wordpress.org/extend/themes/download/twentyeleven.1.4.zip…" Is this another bug?
#6
@
13 years ago
Never mind previous comment. I just noticed from the original screen shot that this is happening on the Updates page, not on the Themes page, which seems to have totally different output.
#7
@
13 years ago
In miqro-screen-shot.png you can see that the second link is not supposed to be displayed as it was in screenshot.jpg.
Screenshot of the message with the missing link.