Filter the Gravatars on credits.php

[miqrogroove]

All Gravatars should be generated by get_avatar() or at least run through apply_filters('get_avatar', $avatar) for the sake of extensibility.

Related: #22329

[GlennM]

Tested on 4.0-alpha-src, added documentation for apply_filters and changed code according to WordPress coding standards.

[GlennM]

I've attached a patch at WordCamp Netherlands Contributor Day.

[ocean90]

Hello GlennM, thanks for your patch. One thing I have noticed is the doc block for the filter, which is not needed. Take a look at ​http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#4-1-duplicate-hooks on how to handle this case.

[GlennM]

Thanks for your reply ocean90. I've updated my patch.

[SergeyBiryukov]

The current patches here pass email hash as $id_or_email parameter, which should only be a user ID, email address, or comment object: tags/3.9.1/src/wp-includes/pluggable.php#L2113​.

This can potentially break any custom code that only expects those three types of values.

I don't see an easy solution here, unless the API endpoint can be modified to return email addresses as well, which I guess is not feasible for privacy reasons.

[miqrogroove]

Replying to SergeyBiryukov:

The current patches here pass email hash as $id_or_email parameter, which should only be a user ID, email address, or comment object

That is actually a documentation error. $id_or_email is an optional parameter.

[SergeyBiryukov]

All Gravatars should be generated by get_avatar() or at least run through apply_filters('get_avatar', $avatar) for the sake of extensibility.

What would be a use case for changing the Gravatars on Credits page?

[SergeyBiryukov]

Oh, I missed the link to #22329. Makes sense.

[SergeyBiryukov]

I guess we should allow for get_avatar() to accept MD5 hash of an email address. See 22650.3.diff​.

[nacin]

get_avatar() is frustratingly pluggable which means we might actually break this screen by doing this.

I'd like to un-plug this function, introduce get_avatar_url(), and such, but that's not going to happen overnight. Suggesting we wait a bit longer here to do this in conjunction with #21195.

[SergeyBiryukov]

Yeah, I've found quite a few plugins in the repository replacing get_avatar():

0gravatar/index.php
add-local-avatar/avatars.php
alkivia/components/gallery/gallery.php
author-or-user-image/Author___Image.php
baw-gravatar-google-image/bawggi.php
bbpress-social-network/ln_livenotifications.php
claimedavatar/claimedavatar.php
default-gravatar-sans/default-gravatar-sans.php
expire-password/pluggable.php
incarnate-for-wordpress/incarnate-for-wordpress.php
nnd-facebook-profile-for-gravatar/NNDFBProfGrav.php
post-author/post_author.php
presstest/mocked/core.php
sem-author-image/sem-author-image.php
simple-intranet-directory/avatars.php
simple-intranet-directory/profiles.php
simple-intranet-directory/profiles_lite.php
simple-local-avatars/simple-local-avatars.php
simple-schools-staff-directory/avatars.php
smartava/smartAva.php
wp-notifications/ln_livenotifications.php
wp-symposium/wp-symposium.php
xmpp-auth/plugged.php

[miqrogroove]

Just need to implement nacin's ideas in a new patch.

[obenland]

Replying to miqrogroove:

Just need to implement nacin's ideas in a new patch.

That needs to happen very soon. Beta is two weeks away and there has been no traction on this ticket in almost a year.

[wonderboymusic]

In 32845:

Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.

Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.