WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#22713 closed defect (bug) (fixed)

Media: Hide "Edit" link in the selection view when it doesn't make sense

Reported by: nacin's profile nacin Owned by: koopersmith's profile koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch needs-testing commit
Focuses: Cc:

Description

Say you are selecting attachments in the media dialog. There is an "Edit" link next to "Clear" and "X selected". It should not always show.

A selection should not be editable when:

  • You are creating a gallery, as to edit it, you should actually create the gallery. (For this, we should declare the view as not editable.)
  • You have only one item selected. (This should probably happen via CSS.)

Attachments (3)

22713.diff​ (1.6 KB) - added by nacin 11 years ago.
22713.2.diff​ (2.3 KB) - added by koopersmith 11 years ago.
22713.3.diff​ (2.3 KB) - added by ocean90 11 years ago.

Download all attachments as: .zip

Change History (11)

@nacin
11 years ago

#1 @nacin
11 years ago

  • Keywords commit added
  • Owner set to koopersmith
  • Status changed from new to assigned

#2 @miqrogroove
11 years ago

# 3: While editing, there is no need for an Edit link because it doesn't do anything.

#3 @koopersmith
11 years ago

  • Keywords needs-refresh needs-body added; commit removed

Doesn't apply cleanly.

#4 @koopersmith
11 years ago

  • Keywords commit added; needs-refresh needs-body removed

Nevermind. Problem on my end.

@koopersmith
11 years ago

#5 @koopersmith
11 years ago

  • Keywords needs-testing added; commit removed

Patch fixes all 3 cases, updates RTL CSS.

@ocean90
11 years ago

#6 @ocean90
11 years ago

Looks good.

#7 @nacin
11 years ago

  • Keywords commit added

#8 @ryan
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 23031:

Media: Hide "Edit" link in the selection view when it doesn't make sense

Props koopersmith, ocean90, nacin
fixes #22713

Note: See TracTickets for help on using tickets.