'Header Image' state isn't removed from images previously used as header image

[johnbillion]

Steps to reproduce:

1. Set your site's header image from Appearance -> Header by uploading an image or choosing one from your media library.
2. Repeat step 1.
3. Visit the Media Library and note that your previous header image still says 'Header Image' next to it.

Not a 3.5 regression as it happens in 3.4.2 too.

[johnbillion]

Affects background images too.

[deltafactory]

As used by get_uploaded_header_images() and on the Appearance -> Header page, the intention of the Header Image label indicates that the current theme had used it as a header image at one time. It's used to provide a list of previous images to select quickly.

What about a separate indicator via _media_states() that shows the "Current Header Image" status?

[ocean90]

deltafactory is right.

I like the idea of "Current Header Image", let's try this.

[deltafactory]

Add Current Header/Background image identifier

[deltafactory]

Looks like I had worked on this back then.. Patch provided.

[deltafactory]

As provided, the patch leaves the "Header Image" and adds "Current Header Image" which is redundant. Is there value to adding to the status, or replacing it?

[coreymcollins]

Above fixes and: removed redundant "Header Image" text on "Current Header Image"

[coreymcollins]

Removed redundant "Header Image" text when displaying "Current Header Image"

[karmatosed]

I think this solution works if as simply adds a new state that makes sense. I can see this being really useful information to a user. Great idea.

[jorbin]

@johnbillion Since you milestoned this, what are you thinking? Is the current patch ready to go in or does it need some changes?

[desrosj]

The patch fixed the problem for me, except under one scenario. If you perform the steps above to have multiple header images on the site, and then select "randomize uploaded headers", no images receive "Current Header Image". Only one of the uploaded headers says "Header Image", at random. All of the images should say "Header Image". Incoming screenshot.

[desrosj]

Improve the patch to fix the problem, and the scenario I described earlier. There was also a stray echo in the first patch that I removed.

[johnbillion]

In 38831:

Customize: Improve the labelling of background and header images in the list mode of the media library.

Props deltafactory, coreymcollins, desrosj
Fixes #22857