WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 24 hours ago

#22857 new enhancement

'Header Image' state isn't removed from images previously used as header image

Reported by: johnbillion Owned by:
Milestone: 4.7 Priority: normal
Severity: normal Version: 3.4.2
Component: Customize Keywords: has-patch needs-testing
Focuses: ui, administration Cc:

Description (last modified by johnbillion)

Steps to reproduce:

  1. Set your site's header image from Appearance -> Header by uploading an image or choosing one from your media library.
  2. Repeat step 1.
  3. Visit the Media Library and note that your previous header image still says 'Header Image' next to it.

Not a 3.5 regression as it happens in 3.4.2 too.

Attachments (3)

22857.patch (1.3 KB) - added by deltafactory 2 years ago.
Add Current Header/Background image identifier
22857.2.diff (1.7 KB) - added by coreymcollins 22 months ago.
Above fixes and: removed redundant "Header Image" text on "Current Header Image"
Screenshot 2014-12-08 10.27.08.png (45.7 KB) - added by coreymcollins 22 months ago.
Removed redundant "Header Image" text when displaying "Current Header Image"

Download all attachments as: .zip

Change History (16)

#1 @johnbillion
4 years ago

  • Description modified (diff)

Affects background images too.

#2 @SergeyBiryukov
4 years ago

  • Component changed from Media to Appearance

#3 @deltafactory
3 years ago

As used by get_uploaded_header_images() and on the Appearance -> Header page, the intention of the Header Image label indicates that the current theme had used it as a header image at one time. It's used to provide a list of previous images to select quickly.

What about a separate indicator via _media_states() that shows the "Current Header Image" status?

#4 @deltafactory
3 years ago

  • Cc jeff@… added

#5 @ocean90
2 years ago

  • Keywords needs-patch added
  • Type changed from defect (bug) to enhancement

deltafactory is right.

I like the idea of "Current Header Image", let's try this.

@deltafactory
2 years ago

Add Current Header/Background image identifier

#6 @deltafactory
2 years ago

  • Keywords has-patch added; needs-patch removed

Looks like I had worked on this back then.. Patch provided.

#7 @deltafactory
2 years ago

  • Focuses ui administration added

As provided, the patch leaves the "Header Image" and adds "Current Header Image" which is redundant. Is there value to adding to the status, or replacing it?

#8 @samuelsidler
2 years ago

  • Keywords needs-testing added

@coreymcollins
22 months ago

Above fixes and: removed redundant "Header Image" text on "Current Header Image"

@coreymcollins
22 months ago

Removed redundant "Header Image" text when displaying "Current Header Image"

#9 @celloexpressions
21 months ago

  • Milestone changed from Awaiting Review to Future Release

#10 @karmatosed
2 months ago

I think this solution works if as simply adds a new state that makes sense. I can see this being really useful information to a user. Great idea.

#11 @johnbillion
4 weeks ago

  • Milestone changed from Future Release to 4.7

#12 @jorbin
13 days ago

@johnbillion Since you milestoned this, what are you thinking? Is the current patch ready to go in or does it need some changes?

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


24 hours ago

Note: See TracTickets for help on using tickets.