WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 9 months ago

#23630 closed enhancement (invalid)

Simplify the DFW implementation

Reported by: lessbloat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

I was sad to see that distraction free writing didn't get picked up for 3.6. I decided to play around with a rough proof of concept to see how difficult it would be to use the existing TinyMCE instance for DFW.

Benefits of handling it this way include:

  • It eliminates the need (and complexity) of juggling multiple instances of TinyMCE
  • We'll be able to remove a bunch of the old DFW code
  • It makes the transition between regular mode and DFW mode much more smooth
  • It can be as fully featured as we want it to be

Attachments (4)

wpicons.png (92.9 KB) - added by lessbloat 3 years ago.
wpicons-2x.png (128.3 KB) - added by lessbloat 3 years ago.
23630.diff (16.1 KB) - added by lessbloat 3 years ago.
23630.1.diff (15.0 KB) - added by lessbloat 2 years ago.

Download all attachments as: .zip

Change History (8)

@lessbloat3 years ago

@lessbloat3 years ago

@lessbloat3 years ago

comment:1 @lessbloat3 years ago

23630.diff​ is a rough first pass at this. The code still needs to be cleaned up, and I'm sure there are bugs. To activate it, click the new DFW icon under the "visual & text" tabs.

Here's a quick screencast of it in action.

@lessbloat2 years ago

comment:2 @lessbloat2 years ago

23630.1.diff​ is a refresh of 23630.diff​ with a few additional minor tweaks.

comment:3 @azaozz2 years ago

  • Keywords early added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

This is starting to look really good, hoping we can polish it a bit more and add it in the next release.

comment:4 @iseulde9 months ago

  • Keywords DFW early removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

We've changed the DFW mode in 4.1. :)

Note: See TracTickets for help on using tickets.