Add __construct function to the "WP_Comment_Query" Class

[ramiy]

Add PHP5 construct function to the comments query class, just like we have constructor functions on WP_Query and WP_User_Query classes.

[westonruter]

Add WP_Comment_Query::__construct() for parity with WP_Query::__construct()

Also:
Add WP_Comment_Query::get_comments() for parity with WP_Query::get_posts()
Add WP_Comment_Query::$comments for parity with WP_Query::$posts
Declare WP_Comment_Query::$query_vars which was previously implicit
Add parse_comment_query action for parity with parse_query in WP_Query.

Relates to #15032

Patches are also on GitHub at:
​https://github.com/x-team/WordPress/tree/24826
​https://github.com/x-team/WordPress/commit/db6105cbaf60ca20501fafea29b0f8277ed03cd3

Passes unit tests for comment group; also added a new test for the changes to WP_Comment_Query (attached).

[wonderboymusic]

This does improve the class, but the patch currently explodes

[westonruter]

Refreshed patch. PR: ​https://github.com/x-team/wordpress-develop/pull/24

[westonruter]

In 24826.diff​ merged core patch and unit test patch into one, and fixed conflicts.

[DrewAPicture]

24826.diff​ needs a refresh.

[morganestes]

Refreshed patch

[DrewAPicture]

@morganestes: Thanks for the refresh. We should probably update the @since versions on WP_Comment_Query::get_comments() and the new constructor to 4.2.0. Barring that, I think we can move this for commit consideration.

@boonebgorges: Any chance you could review this?

[morganestes]

Cleaned up and re-added docblocks to class methods that were split in 4.2.

[boonebgorges]

Yes, I can review. I would only feel comfortable moving forward if I had some time to review the documentation and some backward compatibility issues. If this needs to be committed today to make 4.2.0, let's punt. If it can go in sometime in the next week, let's keep it in 4.2.

[boonebgorges]

In 31793:

Improve method consistency in WP_Comment_Query.

• Introduce a __construct() method, which can accept an array of query vars.
• Move query logic out of query() method and into a new get_comments() method.
• Ensure that $this->comments is set whenever get_comments() returns a value.
• Introduce a parse_query() method, where query vars are parsed with default values and the 'parse_comment_query' action is fired.

These changes bring WP_Comment_Query syntax closer to that of WP_Query.

Props westonruter, morganestes, boonebgorges.
Fixes #24826.

[DrewAPicture]

The hash notation should've been moved to the constructor as well.

[DrewAPicture]

In 31795:

Move the default arguments hash notation for WP_Comment_Query to the new constructor, where the argument definitions were moved in [31793].

Core style dictates that the default arguments should be documented in the same function or method where they are defined.

See [31793].
Fixes #24826.

[rachelbaker]

#16431 was marked as a duplicate.

[DrewAPicture]

In 37355:

Docs: Add a missing hook doc for the parse_comment_query hook, added in [31793].

Props flixos90.
See #24826. Fixes #36740.