WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 months ago

#25036 closed defect (bug) (fixed)

Twenty Fourteen: Ensure old versions of Internet Explorer degrade gracefully

Reported by: taupecat Owned by:
Milestone: 3.8 Priority: low
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Attachments (1)

25036.diff (44.6 KB) - added by iamtakashi 5 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 taupecat8 months ago

Per lancewillett in the Twenty Fourteen office hours today:

We won't officially support IE7 but happy to make sure it's usable and not horribly broken.

Meaning:

Officially, we're going to support IE8+ only. However, visitors coming to Twenty Fourteen in IE7 should see more than just a blank page. This pulls us a little away from WP's core support of IE7 & up, but the task of fixing every IE7 bug in a theme is more onerous and time-consuming than core functionality.

Bugs marked as "IE7" will mostly likely be stamped with "wontfix", however if the reporter also supplies a suggested patch, then that can be tested and applied.

Periodically, checks will be made on IE7 to make sure we're not getting White Screen of Death situations (which we shouldn't anyways), but that will be the extent of our support during the development process.

comment:2 lancewillett8 months ago

  • Milestone changed from Awaiting Review to 3.8
  • Summary changed from Twenty Fourteen: IE7 Discussion and Fixes to Twenty Fourteen: ensure IE7 degrades gracefully

Let's leave this one open until we have the basic usability fixes done.

comment:3 lancewillett7 months ago

  • Priority changed from normal to low

comment:4 lancewillett6 months ago

Still keeping an eye on this, but going to wait a bit more until we have more CSS changes done. Then we can re-test in older IE versions.

iamtakashi5 months ago

comment:5 iamtakashi5 months ago

  • Summary changed from Twenty Fourteen: ensure IE7 degrades gracefully to Twenty Fourteen: Ensure old versions of Internet Explorer degrade gracefully

Attached a style patch for old IEs (previous to IE9)

comment:6 follow-up: lancewillett5 months ago

Patch looks good, only problem I saw was in ie.css two case of padding: auto; which should be padding: 0; since "auto" isn't a valid value there.

comment:7 lancewillett5 months ago

In 26097:

Twenty Fourteen: first pass at older Internet Explorer browser support. Props iamtakashi, see #25036.

comment:8 in reply to: ↑ 6 iamtakashi5 months ago

Replying to lancewillett:

Patch looks good, only problem I saw was in ie.css two case of padding: auto; which should be padding: 0; since "auto" isn't a valid value there.

Oops. Thank you for spotting and fixing the errors!

comment:9 lancewillett5 months ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Let's open new tickets for IE or browser bugs.

Note: See TracTickets for help on using tickets.