Opened 12 years ago
Last modified 6 years ago
#25060 assigned defect (bug)
Quick Edit Comments inline edit save breaks the alternating table row backgrounds
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Quick/Bulk Edit | Keywords: | has-patch |
Focuses: | ui, javascript, administration | Cc: |
Description
Attachments (5)
Change History (20)
#2
@
12 years ago
- Milestone changed from Awaiting Review to 3.7
- Owner set to helen
- Status changed from new to assigned
#4
in reply to:
↑ 3
;
follow-up:
↓ 5
@
12 years ago
Replying to helen:
We have hex values set in JS? :( :( :(
Yes I almost cried too. They are really just used for the green background on un approved comments. Maybe we should be <del> adding a class</del> (The unapproved class is already there ) and update the css?
#5
in reply to:
↑ 4
@
12 years ago
Replying to c3mdigital:
Yes please pretty please.
#6
@
11 years ago
Been fighting with this - latest patch breaks the visual change of parent comment approval when you approve and reply inline.
More than that, though, the zebra striping has issues other than just editing inline - replying inline causes everything to be off. We can still fix this piece of the problem, but just wanted to note that there's more to the entire picture.
#7
@
11 years ago
- Milestone changed from 3.7 to Future Release
Moving based on Helen's observations.
#8
@
11 years ago
This is a place where using :nth-child selectors in CSS would work out way better. IE7 and 8 would just not get zebra striping anymore.
#10
@
10 years ago
Opened #31006 to handle the background hex values in JS thing, as it happens outside of comments as well - will continue off of your start, c3mdigital.
#12
follow-up:
↓ 13
@
10 years ago
Based on [31181], looks like this issue still hasn't been resolved for comments quick edit. @helen: Did you still want to try to resolve this for 4.2?
#13
in reply to:
↑ 12
@
10 years ago
Replying to DrewAPicture:
Did you still want to try to resolve this for 4.2?
That's what #31006 is for - this relies on that.
#14
@
10 years ago
- Focuses ui javascript administration added
- Milestone changed from 4.2 to Future Release
Still blocked, too much to be doing at this point in 4.2. A comments-list-table-only solution could be done, but I think that would put us in a bad position later.
Fixes inline background-color and classes