WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#25551 closed defect (bug) (fixed)

Hook Docs: wp-mail.php

Reported by: radices Owned by: ericlewis
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

Attached patch has docs for
apply_filters( 'enable_post_by_email_configuration'
apply_filters('phone_content', $content);
apply_filters('wp_mail_original_content', $content);
do_action('wp-mail.php')
do_action('publish_phone', $post_ID);

Attachments (2)

wp-mail.diff (1.8 KB) - added by radices 8 years ago.
25551.1.diff (2.2 KB) - added by kpdesign 8 years ago.
Second pass

Download all attachments as: .zip

Change History (10)

@radices
8 years ago

#1 @ericlewis
8 years ago

  • Keywords needs-patch added; has-patch removed

Hi radices,

thanks for the preliminary patch. Please see our inline documentation standards and conform your patch to it.

Some issues are

  • General line spacing. First docblock line should be blank, line break between short description and @since tag.
  • do_action should start with 'Fires after...' or something similar. See the inline docs standard.
  • Document all arguments sent through the hooks.
  • Do not modify any other core functionality, we're just doing docs here (here you replace add_magic_quotes() with wp_slash()
Last edited 8 years ago by johnbillion (previous) (diff)

#2 @DrewAPicture
8 years ago

  • Owner set to ericlewis
  • Status changed from new to reviewing

#3 @radices
8 years ago

I'm not sure how that got changed (wp_slash). I updated my copy of the file just before I starting working on it and only edited the docs part.

#4 @ericlewis
8 years ago

@radices that's strange, this line was changed to use wp_slash() 7 months ago. I'd make sure you're all updated on svn again, and inspect the svn diff output before submitting your next patch.

Also, perhaps related, your diff file's header implies that you aren't creating your patch correctly (see the absolute paths on your local machine included with the diff). Please review the Working with Patches section of the core contributor handbook, and make sure you're using svn diff, either from command line, or through a version control application.

Last edited 8 years ago by ericlewis (previous) (diff)

#5 @DrewAPicture
8 years ago

This still needs a new patch incorporating the suggested changes in comment:1.

@kpdesign
8 years ago

Second pass

#6 @kpdesign
8 years ago

  • Keywords has-patch added; needs-patch removed

25551.1.diff incorporates changes from patch review in comment:1.

#7 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.8

#8 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26129:

Inline documentation for hooks in wp-mail.php.

props kpdesign, radices.
fixes #25551.

Note: See TracTickets for help on using tickets.