WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25800 closed defect (bug) (fixed)

Hook Docs (8): wp-includes/kses.php

Reported by: siobhyb's profile siobhyb Owned by: nacin's profile nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Security Keywords: has-patch commit
Focuses: docs Cc:

Description (last modified by DrewAPicture)


Attachments (2)

25800.patch​ (2.9 KB) - added by siobhyb 11 years ago.
First pass at inline docs for wp-includes/kses.php.
25800.2.patch​ (2.9 KB) - added by DrewAPicture 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @nacin
11 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

This one should be good. :-)

#2 @siobhyb
11 years ago

Sorry for the delay in submitting this patch.

Filters in this file are:

  • wp_kses_allowed_html: This is duplicated a few times in the file and I used the format for duplicate hooks that's described in the handbook: "This filter is documented in path/to/filename.php". Not sure if a different format is required when the duplicate hooks are in the same file?
  • pre_kses
  • safe_style_css

Thanks for reviewing, I'm sure there's some things I've missed/misunderstood. :)

@siobhyb
11 years ago

First pass at inline docs for wp-includes/kses.php.

#3 @DrewAPicture
11 years ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Summary changed from Hook Docs: wp-includes/kses.php to Hook Docs (8): wp-includes/kses.php

Looks like 25800.patch​ could use some work. I'd like to see more complete explanations of the various contexts for the wp_kses_allowed_html hook.

Also, I can totally visualize Nacin rubbing his hands together with glee while reviewing these hook docs :)

#4 @jeremyfelt
11 years ago

  • Component changed from Inline Docs to Security
  • Focuses docs added

@DrewAPicture
11 years ago

#5 @DrewAPicture
11 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

25800.2.patch​ should do it. @nacin: Please review and iterate as you deem necessary.

#6 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27739:

Inline documentation for hooks in wp-includes/kses.php.

props siobhyb, DrewAPicture.
fixes #25800.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. ​View the logs.
11 years ago

Note: See TracTickets for help on using tickets.