WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 14 months ago

Last modified 14 months ago

#25800 closed defect (bug) (fixed)

Hook Docs (8): wp-includes/kses.php

Reported by: siobhyb Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Security Keywords: has-patch commit
Focuses: docs Cc:

Attachments (2)

25800.patch (2.9 KB) - added by siobhyb 18 months ago.
First pass at inline docs for wp-includes/kses.php.
25800.2.patch (2.9 KB) - added by DrewAPicture 14 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 @nacin18 months ago

  • Owner set to nacin
  • Status changed from new to reviewing

This one should be good. :-)

comment:2 @siobhyb18 months ago

Sorry for the delay in submitting this patch.

Filters in this file are:

  • wp_kses_allowed_html: This is duplicated a few times in the file and I used the format for duplicate hooks that's described in the handbook: "This filter is documented in path/to/filename.php". Not sure if a different format is required when the duplicate hooks are in the same file?
  • pre_kses
  • safe_style_css

Thanks for reviewing, I'm sure there's some things I've missed/misunderstood. :)

@siobhyb18 months ago

First pass at inline docs for wp-includes/kses.php.

comment:3 @DrewAPicture17 months ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Summary changed from Hook Docs: wp-includes/kses.php to Hook Docs (8): wp-includes/kses.php

Looks like 25800.patch could use some work. I'd like to see more complete explanations of the various contexts for the wp_kses_allowed_html hook.

Also, I can totally visualize Nacin rubbing his hands together with glee while reviewing these hook docs :)

comment:4 @jeremyfelt16 months ago

  • Component changed from Inline Docs to Security
  • Focuses docs added

@DrewAPicture14 months ago

comment:5 @DrewAPicture14 months ago

  • Keywords has-patch commit added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

25800.2.patch should do it. @nacin: Please review and iterate as you deem necessary.

comment:6 @nacin14 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27739:

Inline documentation for hooks in wp-includes/kses.php.

props siobhyb, DrewAPicture.
fixes #25800.

comment:7 @ircbot14 months ago

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.

Note: See TracTickets for help on using tickets.