WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 18 months ago

Last modified 18 months ago

#25889 closed enhancement (fixed)

Use selected() in touch_time(), page_template_dropdown(), parent_dropdown(), and add head docs

Reported by: meloniq Owned by: wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: General Keywords: has-patch
Focuses: docs, administration, template Cc:

Description

Use selected() in touch_time(), page_template_dropdown(), parent_dropdown(), and add head docs.

Suggested by @SergeyBiryukov in #25879 to separate this changes from adding filter hook.

The touch_time() function probably could be described better.

Attachments (2)

25889.patch (4.2 KB) - added by meloniq 21 months ago.
use selected(), add head docs
25889.2.patch (4.4 KB) - added by DrewAPicture 18 months ago.
Standardized docs

Download all attachments as: .zip

Change History (9)

@meloniq21 months ago

use selected(), add head docs

comment:1 @SergeyBiryukov21 months ago

  • Milestone changed from Awaiting Review to 3.8

comment:2 @matt20 months ago

  • Milestone changed from 3.8 to Future Release

Hasn't been much activity here, let's look at it for after the 3.8 release.

comment:3 @nacin18 months ago

  • Component changed from Template to General
  • Focuses docs administration template added
  • Milestone changed from Future Release to 3.9

@DrewAPicture18 months ago

Standardized docs

comment:4 @DrewAPicture18 months ago

25889.2.patch brings the inline docs in-line with the standards

comment:5 @wonderboymusic18 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 27188:

Use selected() where appropriate in touch_time(), page_template_dropdown(), and parent_dropdown(). Also, add proper docs.

Props meloniq, DrewAPicture.
Fixes #25889.

comment:6 @TobiasBg18 months ago

@wonderboymusic: Seems like you (accidentally?) added get_the_permalink() for #24164 in [27188]?
Well, as the discussion in #24164 agrees, closing that as fixed with [27188] should also be ok.

comment:7 @wonderboymusic18 months ago

EEK. Removed in [27189].

Note: See TracTickets for help on using tickets.