Bug when removing a location when still attached to a menu

[nielsvanrenselaar]

When creating a menu and adding it to a location trough the checkboxes it raises an error when this menu get's removed but still is connected to the location:

Notice: Trying to get property of non-object in wp-includes/nav-menu.php on line 597 Notice: Trying to get property of non-object in wp-includes/nav-menu.php on line 597

In the menu dropdown there is also "empty" slots with comma's, see it's still somewhere in the database.

[nielsvanrenselaar]

Screenshot of dropdown

[nielsvanrenselaar]

Replying to nielsvanrenselaar:

When creating a menu and adding it to a location trough the checkboxes it raises an error when this menu get's removed but still is connected to the location:

Notice: Trying to get property of non-object in wp-includes/nav-menu.php on line 597 Notice: Trying to get property of non-object in wp-includes/nav-menu.php on line 597

In the menu dropdown there is also "empty" slots with comma's, see it's still somewhere in the database.

Sorry, I mean it occurs when you remove the location from i.e. your functions.php. Not when you remove the menu but when the menu is still connected to that location!

[nofearinc]

verify for existing menu location

[nofearinc]

IMO this is not likely to happen way too often, but it's still possible (for example, menus being updated after a theme update). Since the menu locations are fetched as get_theme_mod( 'nav_menu_locations' ) the simple checks in the patch should not cause significant performance drawbacks.

[SergeyBiryukov]

Introduced in [23441].

[SergeyBiryukov]

In 26634:

Avoid a PHP notice on Edit Menus screen when a menu is attached to a non-existing location.

props nofearinc.
fixes #26287.