WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 weeks ago

#26664 closed defect (bug) (fixed)

Restore update_right_now_message()

Reported by: rvola Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: minor Version: 3.8
Component: Upgrade/Install Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

the function update_right_now_message() in WordPress 3.8 has no reason to exist because of the new widget 'At Glance'

/wp-admin/includes/update.php #line 223

Attachments (3)

26664.diff (2.0 KB) - added by obenland 4 months ago.
26664.2.diff (2.1 KB) - added by obenland 5 weeks ago.
26664.3.diff (2.2 KB) - added by obenland 5 weeks ago.

Download all attachments as: .zip

Change History (11)

comment:1 rvola4 months ago

  • Severity changed from normal to minor
  • Summary changed from Removing unnecessary and uncalled function to Removing unnecessary and uncalled function update_right_now_message()

comment:2 SergeyBiryukov4 months ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 3.9

obenland4 months ago

comment:3 obenland4 months ago

  • Keywords has-patch added

comment:4 nacin2 months ago

  • Component changed from Administration to Upgrade/Install
  • Focuses ui administration added

Hmm. This function should probably go back into service. wp_dashboard_right_now() used to call it, but now you don't actually get an update nag there if you're out of date. You should.

obenland5 weeks ago

comment:5 obenland5 weeks ago

.2 patch reactivates update_right_now_message().

Screenshots before & after patch: https://cloudup.com/cI2DHGkjVjS

obenland5 weeks ago

comment:6 DH-Shredder5 weeks ago

  • Keywords commit added

26664.3.diff looks great.

comment:7 nacin3 weeks ago

  • Summary changed from Removing unnecessary and uncalled function update_right_now_message() to Restore update_right_now_message()

comment:8 nacin3 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27711:

Restore the update message in the dashboard, removed in 3.8.

props obenland.
fixes #26664.

Note: See TracTickets for help on using tickets.