WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26891 closed enhancement (wontfix)

Add link to manage menus to customizer

Reported by: celloexpressions Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords:
Focuses: ui Cc:

Description

"Your theme supports 2 menus. Select which menu appears in each location. You can edit your menu content on the Menus screen in the Appearance section."

We should provide a direct link, in addition to explaining where to edit your menus. The admin menu isn't even available in the customizer, so I'm not sure how useful that explanation is anyway.

Attachments (1)

26891.diff (1.1 KB) - added by celloexpressions 6 years ago.
Potential link placement

Download all attachments as: .zip

Change History (8)

@celloexpressions
6 years ago

Potential link placement

#1 @celloexpressions
6 years ago

  • Keywords has-patch added

Not sure if I handled the i18n correctly, or if we need to use the full URL for any reason.

#2 follow-up: @nacin
6 years ago

Yep, we need to use the full URL. So it should be %s and then substituted in.

The problem with this, though, is we're linking to a dashboard page from the customizer, which would unexpectedly close the customizer. The link is actually *less* useful than not having it at all.

#3 in reply to: ↑ 2 ; follow-up: @celloexpressions
6 years ago

Replying to nacin:

The problem with this, though, is we're linking to a dashboard page from the customizer, which would unexpectedly close the customizer. The link is actually *less* useful than not having it at all.

Twenty Fourteen adds a couple of links to customizer section descriptions, so this would be behavior that already exists in new installs by default (guessing you aren't aware of that?). I think leaving the customizer like this is okay, although it can cause changes to be lost. Alternative options would be to open in a new tab (bad for accessibility) or to wait until autosaving functionality makes it into the customizer. Or, we could add a warning onunload if there are unsaved changes (I believe there's history with that approach, but can't remember details).

Related, considering the concern about linking: #26890.

#4 @celloexpressions
6 years ago

  • Focuses ui added

#5 @celloexpressions
6 years ago

  • Keywords has-patch removed
  • Resolution set to wontfix
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

#6 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review deleted

#7 in reply to: ↑ 3 @SergeyBiryukov
6 years ago

Replying to celloexpressions:

Or, we could add a warning onunload if there are unsaved changes (I believe there's history with that approach, but can't remember details).

Related: #25439

Note: See TracTickets for help on using tickets.