WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#26910 closed defect (bug) (fixed)

Red "unapproved" line sometimes shows on approve comments

Reported by: samuelsidler Owned by: nacin
Milestone: 3.8.2 Priority: lowest
Severity: trivial Version: 3.8
Component: Comments Keywords: has-patch commit fixed-major
Focuses: administration Cc:

Description

See attached screenshot.

If the most recent comment is an approved one, and the second most recent comment is an unapproved one, then the (by-default) red "unapproved" line will bleed into the approved comment. The background color of both comments is appropriate, however.

Attachments (2)

26910 screenshot.png (63.7 KB) - added by samuelsidler 8 years ago.
26910.diff (401 bytes) - added by nacin 8 years ago.

Download all attachments as: .zip

Change History (9)

@nacin
8 years ago

#1 @nacin
8 years ago

  • Keywords has-patch added

This was fun to track down.

Each comment gets that arrow not by a left border, but by a background assigned to :before, which is position: absolute with top: 0. That top: 0 would normally be to the top of the comment, since the comment is position: relative.

However, the rule specifying position: relative is #activity-widget #the-comment-list .comment. In this case, you can see that it's actually a pingback, so it doesn't receive the .comment class, but the .pingback class. (The proper generic class is .comment-item.) Thus, top: 0 is relative to the next-highest relatively positioned object, which is #the-comment-list.

The rule also has a background color and a padding of 12px, but it doesn't look like that has any ill effect.

#2 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.9

#3 @nacin
8 years ago

  • Component changed from Administration to Comments
  • Focuses administration added
  • Milestone changed from 3.9 to 3.8.2

This keeps catching me off guard when I visit the make/core dashboard. This is a bug with 3.8 so I'm moving it to 3.8.2 for consideration.

#4 follow-up: @jeffr0
8 years ago

I was just getting ready to create a ticket for this. Thank goodness for search :). @nacin, I see you tagged it for 3.8.2 three weeks ago. Will there be a 3.8.2 before 3.9?

#5 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27564:

Comments dashboard widget: Use the proper class to avoid stretched "unapproved" red lines.

fixes #26910.

#6 in reply to: ↑ 4 @nacin
8 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to jeffr0:

I was just getting ready to create a ticket for this. Thank goodness for search :). @nacin, I see you tagged it for 3.8.2 three weeks ago. Will there be a 3.8.2 before 3.9?

Undetermined.

#7 @nacin
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 27877:

Fix two CSS issues in the 3.8 branch.

  • Comments dashboard widget: Use the proper class to avoid stretched "unapproved" red lines. [27564]
  • Fix the tags input in small viewports and make it a more reasonable size. (Was unusable in Firefox.) [27254]

fixes #26910, #27082.

Note: See TracTickets for help on using tickets.